Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 929683002: Revert "Implement chrome.platformKeys.getKeyPair()." (Closed)

Created:
5 years, 10 months ago by pneubeck (no reviews)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Implement chrome.platformKeys.getKeyPair()." This reverts commit 594333f07c9d287c268f4d04259f74e08fc20bb9. Reverting because it broke gn. R=pneubeck@chromium.org BUG=450167 Committed: https://chromium.googlesource.com/chromium/src/+/fc116b9fd797b804d67c6daaa120d40fc8903000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -799 lines) Patch
M chrome/browser/chromeos/platform_keys/platform_keys.h View 6 chunks +20 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_nss.cc View 16 chunks +65 lines, -175 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_service.h View 3 chunks +17 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_service.cc View 4 chunks +29 lines, -52 lines 0 comments Download
M chrome/browser/extensions/api/platform_keys/platform_keys_api.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/platform_keys/platform_keys_api.cc View 5 chunks +20 lines, -125 lines 0 comments Download
M chrome/common/extensions/api/platform_keys_internal.idl View 3 chunks +2 lines, -17 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/platform_keys_natives.cc View 3 chunks +3 lines, -20 lines 0 comments Download
D chrome/renderer/resources/extensions/platform_keys/get_public_key.js View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/renderer/resources/extensions/platform_keys/internal_api.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/platform_keys_custom_bindings.js View 1 chunk +1 line, -35 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/platform_keys/basic.js View 3 chunks +141 lines, -229 lines 0 comments Download
D chrome/test/data/extensions/api_test/platform_keys/client_1.der View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/platform_keys/client_1_issuer_dn.der View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/platform_keys/client_1_spki.der View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/platform_keys/client_2.der View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/platform_keys/data View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/platform_keys/signature_nohash_pkcs View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/platform_keys/signature_sha1_pkcs View Binary file 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pneubeck (no reviews)
5 years, 10 months ago (2015-02-14 14:02:56 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fc116b9fd797b804d67c6daaa120d40fc8903000 Cr-Commit-Position: refs/heads/master@{#316388}
5 years, 10 months ago (2015-02-14 14:05:20 UTC) #2
pneubeck (no reviews)
5 years, 10 months ago (2015-02-14 14:05:34 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fc116b9fd797b804d67c6daaa120d40fc8903000.

Powered by Google App Engine
This is Rietveld 408576698