Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 929613002: NaCl cleanup: Use validation_cache.h from src/public/ (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl cleanup: Use validation_cache.h from src/public/ Now that NaClValidationCache is declared in src/public/, we can use that declaration from the Chromium side and remove a non-public #include. BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832 TEST=build Committed: https://crrev.com/b4e89950984d01c670fde7d062e1ff4ec7ef9d97 Cr-Commit-Position: refs/heads/master@{#316583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/nacl/loader/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_validation_query.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
5 years, 10 months ago (2015-02-17 16:15:35 UTC) #2
jvoung (off chromium)
lgtm
5 years, 10 months ago (2015-02-17 16:33:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929613002/1
5 years, 10 months ago (2015-02-17 16:37:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 16:40:42 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 16:41:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4e89950984d01c670fde7d062e1ff4ec7ef9d97
Cr-Commit-Position: refs/heads/master@{#316583}

Powered by Google App Engine
This is Rietveld 408576698