[Android] Add PIE support for ICS devices.

build/android/pylib/utils/md5sum.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import logging
 import os
 import tempfile
 import types
 
 from pylib import cmd_helper
 from pylib import constants
 from pylib.utils import device_temp_file
 
 HashAndPath = collections.namedtuple('HashAndPath', ['hash', 'path'])
 
 MD5SUM_DEVICE_LIB_PATH = '/data/local/tmp/md5sum/'
 MD5SUM_DEVICE_BIN_PATH = MD5SUM_DEVICE_LIB_PATH + 'md5sum_bin'
 
 MD5SUM_DEVICE_SCRIPT_FORMAT = (
     'test -f {path} -o -d {path} '
-    '&& LD_LIBRARY_PATH={md5sum_lib} {md5sum_bin} {path}')
+    '&& LD_LIBRARY_PATH={md5sum_lib} {device_pie_wrapper} {md5sum_bin} {path}')
 
 
 def CalculateHostMd5Sums(paths):
   """Calculates the MD5 sum value for all items in |paths|.
 
   Args:
     paths: A list of host paths to md5sum.
   Returns:
     A list of named tuples with 'hash' and 'path' attributes.
   """
@@ skipping 16 matching lines @@
   """
   if isinstance(paths, basestring):
     paths = [paths]
 
   if not device.FileExists(MD5SUM_DEVICE_BIN_PATH):
     device.adb.Push(
         os.path.join(constants.GetOutDirectory(), 'md5sum_dist'),
         MD5SUM_DEVICE_LIB_PATH)
 
   out = []
+
   with tempfile.NamedTemporaryFile() as md5sum_script_file:
     with device_temp_file.DeviceTempFile(
         device.adb) as md5sum_device_script_file:
+      device_pie_wrapper = device.GetDevicePieWrapper()
       md5sum_script = (
           MD5SUM_DEVICE_SCRIPT_FORMAT.format(
               path=p, md5sum_lib=MD5SUM_DEVICE_LIB_PATH,
+              device_pie_wrapper=device_pie_wrapper,
               md5sum_bin=MD5SUM_DEVICE_BIN_PATH)
           for p in paths)
       md5sum_script_file.write('; '.join(md5sum_script))
       md5sum_script_file.flush()
       device.adb.Push(md5sum_script_file.name, md5sum_device_script_file.name)
       out = device.RunShellCommand(['sh', md5sum_device_script_file.name])

[perezju, 2015/02/16 10:25:23]

while we are at it, could we remove the hand-rolled "write to script then run"
logic? This is now already done by RunShellCommand when necessary.

[jbudorick, 2015/02/17 15:15:10]

I'd like to do that, but I don't want to do so in this patch. The MD5 sum logic
is critical for the CQ, so I'd like to keep changes small and isolated.

[perezju, 2015/02/17 16:04:26]

Acknowledged. Maybe start a bug so that we don't forget?

 
-  return [HashAndPath(*l.split(None, 1)) for l in out]
+  return [HashAndPath(*l.split(None, 1)) for l in out if l]