Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3852)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java

Issue 929523002: Add tests to EnhancedBookmarksModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed one todo Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModelTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java b/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java
index 2f5107ca9270f57da78d91db77f324219aab5e50..32d60d1e381aa8657eca12c551509165055a414f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.browser.enhanced_bookmarks;
import org.chromium.base.ObserverList;
+import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.BookmarksBridge;
import org.chromium.chrome.browser.BookmarksBridge.BookmarkItem;
import org.chromium.chrome.browser.BookmarksBridge.BookmarkModelObserver;
@@ -63,6 +64,12 @@ public class EnhancedBookmarksModel {
this();
}
+ @VisibleForTesting
+ EnhancedBookmarksModel(Profile profile) {
+ mBookmarksBridge = new BookmarksBridge(profile);
+ mEnhancedBookmarksBridge = new EnhancedBookmarksBridge(profile);
+ }
+
/**
* Clean up all the bridges. This must be called after done using this class.
*/
@@ -275,7 +282,8 @@ public class EnhancedBookmarksModel {
}
/**
- * @see EnhancedBookmarksBridge#moveBookmark(BookmarkId, BookmarkId)
+ * Calls {@link EnhancedBookmarksBridge#moveBookmark(BookmarkId, BookmarkId)} in a reversed
+ * order of the list, in order to let the last item appear at the top.
*/
public void moveBookmarks(List<BookmarkId> bookmarkIds, BookmarkId newParentId) {
for (int i = bookmarkIds.size() - 1; i >= 0; i--) {
@@ -394,4 +402,12 @@ public class EnhancedBookmarksModel {
public void removeSearchObserver(SearchServiceObserver observer) {
mEnhancedBookmarksBridge.removeSearchObserver(observer);
}
+
+ /**
+ * @see BookmarksBridge#loadEmptyPartnerBookmarkShimForTesting()
+ */
+ @VisibleForTesting
+ public void loadEmptyPartnerBookmarkShimForTesting() {
+ mBookmarksBridge.loadEmptyPartnerBookmarkShimForTesting();
+ }
}
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModelTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698