Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 929493002: Remove dependency on content from remoting_host. (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, chromoting-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on content from remoting_host. The host was depending on content just to access content::BrowserThread. It's cleaner to just pass the references to the threads explicitly. BUG=458581 Committed: https://crrev.com/d5197934178ef0da1b630792cfbda8ddb6b34388 Cr-Commit-Position: refs/heads/master@{#316648} Committed: https://crrev.com/f87c35dec56bbdc30e1d9ccb1744353c6f149f71 Cr-Commit-Position: refs/heads/master@{#316746}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -132 lines) Patch
M chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M remoting/host/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/chromeos/clipboard_aura.h View 1 3 chunks +9 lines, -7 lines 0 comments Download
M remoting/host/chromeos/clipboard_aura.cc View 1 2 4 chunks +23 lines, -73 lines 0 comments Download
M remoting/host/chromeos/clipboard_aura_unittest.cc View 1 2 3 5 chunks +9 lines, -6 lines 0 comments Download
M remoting/host/chromoting_host_context.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M remoting/host/chromoting_host_context.cc View 1 2 chunks +27 lines, -38 lines 0 comments Download
M remoting/host/input_injector_chromeos.cc View 1 2 3 4 5 2 chunks +1 line, -3 lines 0 comments Download
M remoting/remoting_host.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 33 (14 generated)
Sergey Ulanov
5 years, 10 months ago (2015-02-13 18:33:21 UTC) #4
kelvinp
lgtm
5 years, 10 months ago (2015-02-13 18:44:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929493002/40001
5 years, 10 months ago (2015-02-13 18:45:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/8163)
5 years, 10 months ago (2015-02-13 19:03:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929493002/60001
5 years, 10 months ago (2015-02-13 19:37:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/8191)
5 years, 10 months ago (2015-02-13 19:48:42 UTC) #15
Sergey Ulanov
PTAL. Now also cleaned up ClipboardAura which had dependency on BrowserThread.
5 years, 10 months ago (2015-02-13 21:50:51 UTC) #16
Sergey Ulanov
On 2015/02/13 21:50:51, Sergey Ulanov wrote: > PTAL. Now also cleaned up ClipboardAura which had ...
5 years, 10 months ago (2015-02-17 18:15:46 UTC) #17
kelvinp
Sorry for the delay. Looks good to me. https://codereview.chromium.org/929493002/diff/120001/remoting/host/chromeos/clipboard_aura.cc File remoting/host/chromeos/clipboard_aura.cc (right): https://codereview.chromium.org/929493002/diff/120001/remoting/host/chromeos/clipboard_aura.cc#newcode23 remoting/host/chromeos/clipboard_aura.cc:23: ClipboardAura::ClipboardAura() ...
5 years, 10 months ago (2015-02-17 18:30:21 UTC) #18
Sergey Ulanov
https://codereview.chromium.org/929493002/diff/120001/remoting/host/chromeos/clipboard_aura.cc File remoting/host/chromeos/clipboard_aura.cc (right): https://codereview.chromium.org/929493002/diff/120001/remoting/host/chromeos/clipboard_aura.cc#newcode23 remoting/host/chromeos/clipboard_aura.cc:23: ClipboardAura::ClipboardAura() On 2015/02/17 18:30:21, kelvinp wrote: > Please add ...
5 years, 10 months ago (2015-02-17 18:46:40 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929493002/120001
5 years, 10 months ago (2015-02-17 18:48:13 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/59109)
5 years, 10 months ago (2015-02-17 18:50:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929493002/160001
5 years, 10 months ago (2015-02-17 19:53:03 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:160001)
5 years, 10 months ago (2015-02-17 20:43:27 UTC) #27
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/d5197934178ef0da1b630792cfbda8ddb6b34388 Cr-Commit-Position: refs/heads/master@{#316648}
5 years, 10 months ago (2015-02-17 20:44:11 UTC) #28
Charlie Reis
A revert of this CL (patchset #5 id:160001) has been created in https://codereview.chromium.org/923773003/ by creis@chromium.org. ...
5 years, 10 months ago (2015-02-17 21:43:52 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929493002/180001
5 years, 10 months ago (2015-02-18 01:25:27 UTC) #31
commit-bot: I haz the power
Committed patchset #6 (id:180001)
5 years, 10 months ago (2015-02-18 02:19:22 UTC) #32
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 02:20:03 UTC) #33
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f87c35dec56bbdc30e1d9ccb1744353c6f149f71
Cr-Commit-Position: refs/heads/master@{#316746}

Powered by Google App Engine
This is Rietveld 408576698