Issue 929483006: Allowing size increase of nacl_helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 929483006: Allowing size increase of nacl_helper. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium

Modified:
5 years, 10 months ago

Reviewers:
bbudge

CC:
chromium-reviews, llandwerlin-old, jam, piman, Will Harris, tonyg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Allowing size increase of nacl_helper. It's pretty clear from the sizes graph (http://goo.gl/zdhb0b) that the cl https://codereview.chromium.org/905023005 causes an increase of 40k of nacl_helper on Linux x64. As per Chrome policy on which states that increases < 100k are alright. http://dev.chromium.org/developers/tree-sheriffs/perf-sheriffs says: "If sizes fails and the jump is <100k, update expections." TBR=bbudge CC=piman,llandwerlin,jam,wfh BUG=455409 Committed: https://crrev.com/c4616ff5326e03d4dd04bb3c34471a4bde4afb52 Cr-Commit-Position: refs/heads/master@{#318018}