Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 929483005: Remove forward-declaration of non-existent class (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove forward-declaration of non-existent class GoogleURLTrackerNavigationHelper class was completely removed as part of https://codereview.chromium.org/808253006/ but a forward-declaration was left in the code, remove it. BUG=None R=isherman@chromium.org Committed: https://crrev.com/e0d02fe3d305316aacfcd039edb596e3f2f1f005 Cr-Commit-Position: refs/heads/master@{#317466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M components/google/core/browser/google_url_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
sdefresne
5 years, 10 months ago (2015-02-20 16:39:55 UTC) #1
Ilya Sherman
LGTM
5 years, 10 months ago (2015-02-20 23:12:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929483005/1
5 years, 10 months ago (2015-02-20 23:13:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-21 00:55:17 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 00:55:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0d02fe3d305316aacfcd039edb596e3f2f1f005
Cr-Commit-Position: refs/heads/master@{#317466}

Powered by Google App Engine
This is Rietveld 408576698