Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/browser/policy/policy_path_parser_unittest.cc

Issue 929483002: Disabling PolicyPathParserTests.AllPlatformVariables on Mac OS X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/policy_path_parser_unittest.cc
diff --git a/chrome/browser/policy/policy_path_parser_unittest.cc b/chrome/browser/policy/policy_path_parser_unittest.cc
index 9ae45973d94d6814aafcd783537f94fae4dfe171..b6437a4d3bed91f3fbe5803a756448f50e986ab0 100644
--- a/chrome/browser/policy/policy_path_parser_unittest.cc
+++ b/chrome/browser/policy/policy_path_parser_unittest.cc
@@ -23,7 +23,14 @@ class PolicyPathParserTests : public testing::Test {
// TODO(pastarmovj): Modify test or change the logic after investigating why it
// is flaky. Please only redisable after it has had a chance to run for a few
// times. See bug http://crbug.com/327520 for context.
-TEST_F(PolicyPathParserTests, AllPlatformVariables) {
+// TODO(pastarmovj): Disabling on Mac OS X as the test is flaky. See
+// crbug.com/458590 for details.
+#if defined(OS_MACOSX)
+#define MAYBE_AllPlatformVariables DISABLED_AllPlatformVariables
+#else
+#define MAYBE_AllPlatformVariables AllPlatformVariables
+#endif
+TEST_F(PolicyPathParserTests, MAYBE_AllPlatformVariables) {
// No vars whatsoever no substitution should occur.
base::FilePath::StringType no_vars(FILE_PATH_LITERAL("//$C/shares"));
base::FilePath::StringType no_vars_result =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698