FontFamily SkTArrays can be moved.

FontFamily SkTArrays can be moved.

The FontFamily type in SkFontConfigParser_android.h contains two fields
of type SkTArray. Both of these contain types which can be moved
instead of calling constructors and destructors on resize. This change
avoids a number of unneeded SkString refs and unrefs.

Committed: https://skia.googlesource.com/skia/+/b5d0ce6bd4fef192a9908562b5a01bc01683c7bb

[bungeman-skia, 2015-02-13 18:22:37]

bungeman@google.com changed reviewers:
+ djsollen@google.com

[bungeman-skia, 2015-02-13 18:22:38]

Found this change while cleaning out my stash. Should save a bit of copying and
reffing/unreffing of SkString::Recs.

[djsollen, 2015-02-13 18:29:38]

Is it worth it since we only parse the font file 1x?  If so, then we should at
least add a little documentation stating that the data types used here must
remain memcpy compatible.

[bungeman-skia, 2015-02-13 19:32:22]

On 2015/02/13 18:29:38, djsollen wrote:
> Is it worth it since we only parse the font file 1x?  If so, then we should at
> least add a little documentation stating that the data types used here must
> remain memcpy compatible.

In Chromium this is (unfortunately) part of each sandboxed processes startup, so
any little bit helps. (This time is dominated by actually loading the font files
later to verify that they exist, are basically sane, and to fill out information
not given in the configuration xml. However, it does add up.) There are plans to
avoid re-parsing everything in each sandbox process in the future, but that's
still quite a way off.

SkString is always going to be trivially movable (there are existing users of
SkTArray<SkString, true>), and FontFileInfo is declared right above this and is
also quite unlikely to ever be not trivially movable. I've added a comment to
FontFileInfo to document this in PS2.

[djsollen, 2015-02-13 19:37:06]

lgtm

[bungeman-skia, 2015-02-13 19:37:40]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-02-13 19:38:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/929473002/2

[commit-bot: I haz the power, 2015-02-13 19:49:10]

Committed patchset #2 (id:2) as
https://skia.googlesource.com/skia/+/b5d0ce6bd4fef192a9908562b5a01bc01683c7bb