Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 929463004: Sets render_frame_proxy_ to null in the RenderFrameImpl when destroying the RenderFrameProxy. (Closed)

Created:
5 years, 10 months ago by lfg
Modified:
5 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sets render_frame_proxy_ to null in the RenderFrameImpl when destroying the RenderFrameProxy. This fixes with a use-after-free in the RenderFrameProxy reported by the asan bots, but uncovers another one. TEST=NavigateRemoteFrame BUG=357747 Committed: https://crrev.com/912887b4a462f216fca73228de49b4c6cc980da4 Cr-Commit-Position: refs/heads/master@{#316337}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/renderer/render_frame_proxy.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lfg
PTAL. Thanks!
5 years, 10 months ago (2015-02-13 21:24:19 UTC) #2
nasko
LGTM Let's mention in the description of the CL that it helps with UaF, but ...
5 years, 10 months ago (2015-02-13 21:28:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929463004/20001
5 years, 10 months ago (2015-02-13 22:54:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-14 00:04:09 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 00:05:09 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/912887b4a462f216fca73228de49b4c6cc980da4
Cr-Commit-Position: refs/heads/master@{#316337}

Powered by Google App Engine
This is Rietveld 408576698