Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 929433006: Change jingle_unittests target to a test executable. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, brettw, Dirk Pranke, Nicolas Zea
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change jingle_unittests target to a test executable. Everything seems to link now. Tested with the following command lines: $ gn gen out-gn $ ninja -C out-gn/ jingle_unittests $ out-gn/jingle_unittests This fixes one more TODO(GYP). BUG=None TEST=see above R=sergeyu@chromium.org Committed: https://crrev.com/1b1006ac316595d0a849a167816d46e8fb01177b Cr-Commit-Position: refs/heads/master@{#317045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M jingle/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 10 months ago (2015-02-19 02:02:50 UTC) #1
Sergey Ulanov
lgtm
5 years, 10 months ago (2015-02-19 05:02:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929433006/1
5 years, 10 months ago (2015-02-19 14:43:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 14:46:39 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 14:47:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b1006ac316595d0a849a167816d46e8fb01177b
Cr-Commit-Position: refs/heads/master@{#317045}

Powered by Google App Engine
This is Rietveld 408576698