Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 929433004: More updates to getrealpan (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More updates to getrealpan End-to-end flow works with trunk + this CL. BUG=451286 Committed: https://crrev.com/de0ab472b7b7d497a0d7facda6a7f6a17b791658 Cr-Commit-Position: refs/heads/master@{#316350}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M components/autofill/core/browser/wallet/real_pan_wallet_client.cc View 3 chunks +7 lines, -3 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
Evan Stade
https://codereview.chromium.org/929433004/diff/1/components/autofill/core/browser/wallet/real_pan_wallet_client.cc File components/autofill/core/browser/wallet/real_pan_wallet_client.cc (left): https://codereview.chromium.org/929433004/diff/1/components/autofill/core/browser/wallet/real_pan_wallet_client.cc#oldcode186 components/autofill/core/browser/wallet/real_pan_wallet_client.cc:186: request_->AddExtraRequestHeader("Authorization: Bearer " + access_token_); (no behavior change, just ...
5 years, 10 months ago (2015-02-13 22:22:33 UTC) #2
brettw
lgtm
5 years, 10 months ago (2015-02-13 23:33:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929433004/1
5 years, 10 months ago (2015-02-13 23:36:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25187)
5 years, 10 months ago (2015-02-14 00:29:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929433004/1
5 years, 10 months ago (2015-02-14 00:38:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 01:14:03 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 01:14:50 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/de0ab472b7b7d497a0d7facda6a7f6a17b791658
Cr-Commit-Position: refs/heads/master@{#316350}

Powered by Google App Engine
This is Rietveld 408576698