Fix generate_policy_source.py to honour supported_on ranges.

components/policy/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//third_party/protobuf/proto_library.gni")
 import("//tools/grit/grit_rule.gni")
 
 if (is_component_build) {
   component("policy_component") {
@@ skipping 49 matching lines @@
   chrome_settings_proto_path = "$policy_gen_dir/chrome_settings.proto"
 
   constants_header_path = "$policy_gen_dir/policy_constants.h"
   constants_source_path = "$policy_gen_dir/policy_constants.cc"
   protobuf_decoder_path = "$policy_gen_dir/cloud_policy_generated.cc"
   app_restrictions_path =
       "$android_resources_gen_dir/xml-v21/app_restrictions.xml"
   app_resources_path =
       "$android_resources_gen_dir/values-v21/restriction_values.xml"
 
+  # Obtain Chromium version.
+  version_py_abspath = "//build/util/version.py"
+  chrome_version_abspath = "//chrome/VERSION"
+  chrome_version_path = rebase_path(chrome_version_abspath, root_build_dir)
+  version_full = exec_script(version_py_abspath,
+                             [
+                               "-f",
+                               chrome_version_path,
+                               "-t @MAJOR@.@MINOR@.@BUILD@.@PATCH@",
+                             ],
+                             "trim string",
+                             [ chrome_version_abspath ])

[Mattias Nissler (ping if slow), 2015/02/18 10:34:42]

I have no idea where this came from, but I assume you copied it from somewhere?
If so, can you please CC the respective OWNER/reviewer to perform a sanity
check?

[Thiemo Nagel, 2015/02/18 17:31:56]

Done.

[brettw, 2015/02/23 19:19:07]

I have tried very hard not to add this kind of thing. We did it a lot in GYP
because everything is so slow you don't notice that everything grinds to a halt
while we run python and do a bunch of disk I/O. But this really adds up.

For this version thing in particular, the GYP build runs version.py a *lot* of
times over and over in the build. We've always been able to avoid doing the same
in the GN build.

Your use of this is somewhat different than the others. Usually version.py is
called to generate some header so my standard instructions won't work. But since
this is just being used to call generate_policy_source.py, that script itself
can just compute what it needs at build time (rather than GN/GYP time).

So your action below can just run version.py, or you can have the script load
the VERSION. Either way, be sure to add any files the script depends on
(VERSION/version.py or both) to the inputs of the action below.

[Thiemo Nagel, 2015/04/22 17:26:47]

Done.

+
   action("cloud_policy_code_generate") {
     script = "tools/generate_policy_source.py"
 
     if (is_chromeos) {
       chromeos_flag = "1"
     } else {
       chromeos_flag = "0"
     }
 
     inputs = [
@@ skipping 24 matching lines @@
       "--chrome-settings-protobuf=" +
           rebase_path(chrome_settings_proto_path, root_build_dir),
       "--cloud-policy-protobuf=" +
           rebase_path(cloud_policy_proto_path, root_build_dir),
       "--cloud-policy-decoder=" +
           rebase_path(protobuf_decoder_path, root_build_dir),
       "--app-restrictions-definition=" +
           rebase_path(app_restrictions_path, root_build_dir),
       "--app-restrictions-resources=" +
           rebase_path(app_resources_path, root_build_dir),
+      version_full,
       os,
       chromeos_flag,
       rebase_path("resources/policy_templates.json", root_build_dir),
     ]
   }
 
   proto_library("cloud_policy_proto_generated_compile") {
     sources = [
       cloud_policy_proto_path,
     ]
@@ skipping 88 matching lines @@
     deps = [
       ":policy_component",
       ":test_support",
       "//components/policy/proto",
       "//testing/gmock",
       "//testing/gtest",
     ]
   }
 }
 #TODO(GYP) policy templates, chrome_manifest_bundle