Separate host desktop related functionality into remoting.HostDesktop

remoting/webapp/base/js/window_shape.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling setting of the local app window shape to account for windows
  * on the remote desktop, as well as any client-side UI.
  */
 
@@ skipping 51 matching lines @@
  */
 remoting.WindowShape.prototype.updateClientWindowShape = function() {
   if (!remoting.WindowShape.isSupported()) {
     return;
   }
 
   var rects = this.desktopRects_.slice();
   for (var i = 0; i < this.clientUICallbacks_.length; ++i) {
     this.clientUICallbacks_[i].addToRegion(rects);
   }
-  for (var i = 0; i < rects.length; ++i) {
-    var rect = /** @type {ClientRect} */ (rects[i]);
-    var left = Math.floor(rect.left);
-    var right = Math.ceil(rect.left + rect.width);
-    var top = Math.floor(rect.top);
-    var bottom = Math.ceil(rect.top + rect.height);
-    rects[i] = { left: left,
-                 top: top,
-                 width: right - left,
-                 height: bottom - top };
-  }

[Jamie, 2015/02/19 22:44:04]

Apologies for the churn, but now I see the code removed, I think I was wrong
about moving it. It's mostly needed to handle client UI callbacks that return
non-integer values (for example, because they measure DOM elements, which can
have fractional coordinates). Forcing the shape reported by the host desktop to
have integer coordinates is not going to help with that, so I think this part of
the change should be reverted.

[kelvinp, 2015/02/19 23:36:20]

Done.

   chrome.app.window.current().setShape({rects: rects});
 };
 
 
 /**
  * @interface
  */
 remoting.WindowShape.ClientUI = function () {
 };
 
 /**
  * Add the context menu's bounding rectangle to the specified region.
  *
  * @param {Array<{left: number, top: number, width: number, height: number}>}
  *     rects
  */
 remoting.WindowShape.ClientUI.prototype.addToRegion = function(rects) {};
 
 
 /** @type {remoting.WindowShape} */
 remoting.windowShape = new remoting.WindowShape();