Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: remoting/webapp/crd/js/host_desktop.js

Issue 929323003: Separate host desktop related functionality into remoting.HostDesktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 /**
6 * @fileoverview
7 * Interface abstracting the functionality of the HostDesktop.
8 */
9
10 var remoting = remoting || {};
11
12 (function() {
13
14 'use strict';
15
16 /**
17 * @interface
18 * @extends {base.EventSource}
19 */
20 remoting.HostDesktop = function() {};
21
22 /** @return {boolean} Whether the host rate limits desktop-resize requests. */
23 remoting.HostDesktop.prototype.hasResizeRateLimit = function() {};
Jamie 2015/02/18 23:06:19 I don't think you need this. It was important to a
kelvinp 2015/02/19 20:58:15 Done.
24
25 /** @return {boolean} Whether the host supports desktop resizing. */
26 remoting.HostDesktop.prototype.isResizable = function() {};
Jamie 2015/02/18 23:06:19 I'm not sure you need this either. Some Linux host
kelvinp 2015/02/19 20:58:15 Yes, I think it would be nice if we can expose tha
27
28 /** @enum {string} */
29 remoting.HostDesktop.Events = {
30 // Fired when the size of the host desktop changes with no event data.
31 sizeChanged: 'sizeChanged',
32 // Fired when the shape of the host desktop changes with an array of
33 // rectangles of desktop shapes as the event data.
34 // Array<{left:number, top:number, width:number, height:number}>
35 shapeChanged: 'shapeChanged'
36 };
37
38 /**
39 * @return {{width:number, height:number, xDpi:number, yDpi:number}}
40 * The dimensions and DPI settings of the host desktop.
41 */
42 remoting.HostDesktop.prototype.getDimensions = function() {};
43
44 /**
45 * Resize the desktop of the host to |width|, |height| and |dpi|.
46 *
47 * @param {number} width
Jamie 2015/02/18 23:06:19 I think |width| and |height| are in DIPs, correct?
kelvinp 2015/02/19 20:58:15 Yes. Comments updated.
48 * @param {number} height
49 * @param {number} dpi
50 */
51 remoting.HostDesktop.prototype.resize = function(width, height, dpi) {};
52
53 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698