sdk/lib/_internal/compiler/js_lib/js_names.dart - Issue 929313002: Use an enum in embedded_names as input to JS_GET_NAME.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_names.dart

Issue 929313002: Use an enum in embedded_names as input to JS_GET_NAME. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase + comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/js_lib/js_mirrors.dart ('k') | sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/js_lib/js_names.dart

diff --git a/sdk/lib/_internal/compiler/js_lib/js_names.dart b/sdk/lib/_internal/compiler/js_lib/js_names.dart

index 3933e787245a3b25727d7a977dd0d5c52a1b49bb..95f7e4902e5acf094b9a1902d3c7ce0f25d03d68 100644

--- a/sdk/lib/_internal/compiler/js_lib/js_names.dart

+++ b/sdk/lib/_internal/compiler/js_lib/js_names.dart

@@ -5,6 +5,7 @@

library dart._js_names;

import 'dart:_js_embedded_names' show

+ JsGetName,

MANGLED_GLOBAL_NAMES,

MANGLED_NAMES;

@@ -53,9 +54,9 @@ Map<String, String> computeMangledNames(jsMangledNames, bool isGlobal) {

preserveNames();

var keys = extractKeys(jsMangledNames);

var result = <String, String>{};

- String getterPrefix = JS_GET_NAME('GETTER_PREFIX');

+ String getterPrefix = JS_GET_NAME(JsGetName.GETTER_PREFIX);

int getterPrefixLength = getterPrefix.length;

- String setterPrefix = JS_GET_NAME('SETTER_PREFIX');

+ String setterPrefix = JS_GET_NAME(JsGetName.SETTER_PREFIX);

for (String key in keys) {

String value = JS('String', '#[#]', jsMangledNames, key);

result[key] = value;

« no previous file with comments | « sdk/lib/_internal/compiler/js_lib/js_mirrors.dart ('k') | sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart » ('j') | no next file with comments »