Use an enum in embedded_names as input to JS_GET_NAME.

sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart._js_mirrors;
 
 import 'dart:_js_embedded_names' show
+    JsGetName,
     ALL_CLASSES,
     LAZIES,
     LIBRARIES,
     STATICS,
     TYPE_INFORMATION,
     TYPEDEF_PREDICATE_PROPERTY_NAME,
     TYPEDEF_TYPE_PROPERTY_NAME;
 
 import 'dart:collection' show
     UnmodifiableListView,
@@ skipping 46 matching lines @@
     Interceptor,
     JSArray,
     JSExtendableArray,
     getInterceptor;
 
 import 'dart:_js_names';
 
 const String METHODS_WITH_OPTIONAL_ARGUMENTS = r'$methodsWithOptionalArguments';
 
 bool hasReflectableProperty(var jsFunction) {
-  return JS('bool', '# in #', JS_GET_NAME("REFLECTABLE"), jsFunction);
+  return JS('bool', '# in #', JS_GET_NAME(JsGetName.REFLECTABLE), jsFunction);
 }
 
 /// No-op method that is called to inform the compiler that tree-shaking needs
 /// to be disabled.
 disableTreeShaking() => preserveNames();
 
 /// No-op method that is called to inform the compiler that metadata must be
 /// preserved at runtime.
 preserveMetadata() {}
 
@@ skipping 558 matching lines @@
     //  MyTypedef: {
     //     "^": "Object;",
     //     $typedefType: 58,
     //     $$isTypedef: true
     //  }
     //  The typedefType is the index into the metadata table.
     int index = JS('int', '#[#]', descriptor, TYPEDEF_TYPE_PROPERTY_NAME);
     mirror = new JsTypedefMirror(symbol, mangledName, getMetadata(index));
   } else {
     fields = JS('', '#[#]', descriptor,
-        JS_GET_NAME('CLASS_DESCRIPTOR_PROPERTY'));
+        JS_GET_NAME(JsGetName.CLASS_DESCRIPTOR_PROPERTY));
     if (fields is List) {
       fieldsMetadata = fields.getRange(1, fields.length).toList();
       fields = fields[0];
     }
     if (fields is! String) {
       // TODO(ahe): This is CSP mode.  Find a way to determine the
       // fields of this class.
       fields = '';
     }
   }
@@ skipping 1075 matching lines @@
     }
     parseCompactFieldSpecification(
         fieldOwner, instanceFieldSpecfication, false, result);
 
     var statics = JS_EMBEDDED_GLOBAL('', STATICS);
     var staticDescriptor = JS('', '#[#]', statics, _mangledName);
     if (staticDescriptor != null) {
       parseCompactFieldSpecification(
           fieldOwner,
           JS('', '#[#]',
-              staticDescriptor, JS_GET_NAME('CLASS_DESCRIPTOR_PROPERTY')),
+              staticDescriptor,
+              JS_GET_NAME(JsGetName.CLASS_DESCRIPTOR_PROPERTY)),
           true, result);
     }
     return result;
   }
 
   List<VariableMirror> get _fields {
     if (_cachedFields != null) return _cachedFields;
     return _cachedFields = _getFieldsWithOwner(this);
   }
 
@@ skipping 385 matching lines @@
     String accessorName = jsName = field.substring(0, length);
     int divider = field.indexOf(':');
     if (divider > 0) {
       accessorName = accessorName.substring(0, divider);
       jsName = field.substring(divider + 1);
     }
     var unmangledName;
     if (isStatic) {
       unmangledName = mangledGlobalNames[accessorName];
     } else {
-      String getterPrefix = JS_GET_NAME('GETTER_PREFIX');
+      String getterPrefix = JS_GET_NAME(JsGetName.GETTER_PREFIX);
       unmangledName = mangledNames['$getterPrefix$accessorName'];
     }
     if (unmangledName == null) unmangledName = accessorName;
     if (!hasSetter) {
       // TODO(ahe): This is a hack to handle checked setters in checked mode.
       var setterName = s('$unmangledName=');
       for (JsMethodMirror method in owner._methods) {
         if (method.simpleName == setterName) {
           isFinal = false;
           break;
@@ skipping 58 matching lines @@
       : super(reflectee);
 
   MethodMirror get function {
     String cacheName = Primitives.mirrorFunctionCacheName;
     JsMethodMirror cachedFunction;
     // TODO(ahe): Restore caching.
     //= JS('JsMethodMirror|Null', r'#.constructor[#]', reflectee, cacheName);
     if (cachedFunction != null) return cachedFunction;
     disableTreeShaking();
     // TODO(ahe): What about optional parameters (named or not).
-    String callPrefix = "${JS_GET_NAME("CALL_PREFIX")}\$";
+    String callPrefix = "${JS_GET_NAME(JsGetName.CALL_PREFIX)}\$";
     var extractCallName = JS('', r'''
 function(reflectee) {
   for (var property in reflectee) {
     if (# == property.substring(0, #) &&
         property[#] >= '0' &&
         property[#] <= '9') return property;
   }
   return null;
 }
 ''', callPrefix, callPrefix.length, callPrefix.length, callPrefix.length);
@@ skipping 691 matching lines @@
   case '~':
     return true;
   default:
     return false;
   }
 }
 
 /// Returns true if the key represent ancillary reflection data, that is, not a
 /// method.
 bool isReflectiveDataInPrototype(String key) {
-  if (key == JS_GET_NAME('CLASS_DESCRIPTOR_PROPERTY') ||
+  if (key == JS_GET_NAME(JsGetName.CLASS_DESCRIPTOR_PROPERTY) ||
       key == METHODS_WITH_OPTIONAL_ARGUMENTS) {
     return true;
   }
   String firstChar = key[0];
   return firstChar == '*' || firstChar == '+';
 }
 
 bool isNoSuchMethodStub(var jsFunction) {
   return JS('bool', r'#.$reflectable == 2', jsFunction);
 }
@@ skipping 68 matching lines @@
   // have a part (following a '.') that starts with '_'.
   const int UNDERSCORE = 0x5f;
   if (name.isEmpty) return true;
   int index = -1;
   do {
     if (name.codeUnitAt(index + 1) == UNDERSCORE) return false;
     index = name.indexOf('.', index + 1);
   } while (index >= 0 && index + 1 < name.length);
   return true;
 }