Use an enum in embedded_names as input to JS_GET_NAME.

pkg/compiler/lib/src/js_backend/namer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * Assigns JavaScript identifiers to Dart variables, class-names and members.
  */
 class Namer implements ClosureNamer {
@@ skipping 283 matching lines @@
   String get noSuchMethodName => publicInstanceMethodNameByArity(
       Compiler.NO_SUCH_METHOD, Compiler.NO_SUCH_METHOD_ARG_COUNT);
   /**
    * Some closures must contain their name. The name is stored in
    * [STATIC_CLOSURE_NAME_NAME].
    */
   String get STATIC_CLOSURE_NAME_NAME => r'$name';
   String get closureInvocationSelectorName => Compiler.CALL_OPERATOR_NAME;
   bool get shouldMinify => false;
 
-  String getNameForJsGetName(Node node, String name) {
+  /// Returns the string that is to be used as the result of a call to
+  /// [JS_GET_NAME] at [node] with argument [name].
+  String getNameForJsGetName(Node node, JsGetName name) {
     switch (name) {
-      case 'GETTER_PREFIX': return getterPrefix;
-      case 'SETTER_PREFIX': return setterPrefix;
-      case 'CALL_PREFIX': return callPrefix;
-      case 'CALL_CATCH_ALL': return callCatchAllName;
-      case 'REFLECTABLE': return reflectableField;
-      case 'CLASS_DESCRIPTOR_PROPERTY': return classDescriptorProperty;
-      case 'REQUIRED_PARAMETER_PROPERTY': return requiredParameterField;
-      case 'DEFAULT_VALUES_PROPERTY': return defaultValuesField;
-      case 'CALL_NAME_PROPERTY': return callNameField;
+      case JsGetName.GETTER_PREFIX: return getterPrefix;
+      case JsGetName.SETTER_PREFIX: return setterPrefix;
+      case JsGetName.CALL_PREFIX: return callPrefix;
+      case JsGetName.CALL_CATCH_ALL: return callCatchAllName;
+      case JsGetName.REFLECTABLE: return reflectableField;
+      case JsGetName.CLASS_DESCRIPTOR_PROPERTY:
+        return classDescriptorProperty;
+      case JsGetName.REQUIRED_PARAMETER_PROPERTY:
+        return requiredParameterField;
+      case JsGetName.DEFAULT_VALUES_PROPERTY: return defaultValuesField;
+      case JsGetName.CALL_NAME_PROPERTY: return callNameField;
       default:
-        compiler.reportError(
-            node, MessageKind.GENERIC,
-            {'text': 'Error: Namer has no name for "$name".'});
-        return 'BROKEN';
+        assert(invariant(node, "Missing JsGetName value in namer!"));

[floitsch, 2015/02/18 13:00:44]

Keep the 'compiler.reportError'.

[herhut, 2015/02/19 10:27:28]

Done.

+        return null;
     }
   }
 
   String constantName(ConstantValue constant) {
     // In the current implementation it doesn't make sense to give names to
     // function constants since the function-implementation itself serves as
     // constant and can be accessed directly.
     assert(!constant.isFunction);
     String result = constantNames[constant];
     if (result == null) {
@@ skipping 1093 matching lines @@
         if (!first) {
           sb.write('_');
         }
         sb.write('_');
         visit(parameter);
         first = true;
       }
     }
   }
 }