Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 929303003: clang-formatting files in //net/cookies to clear up a diff. (Closed)

Created:
5 years, 10 months ago by Mike West
Modified:
5 years, 10 months ago
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang-formatting files in //net/cookies to clear up a diff. The change in https://codereview.chromium.org/876973003 is vaguely incomprehensible because of all the clang-format changes. This patch formats all the files that patch touches in the hopes of clearing up the diff. BUG=459154 Committed: https://crrev.com/be84af3196d7b6ce5c49c02b2fa47685f8d417c9 Cr-Commit-Position: refs/heads/master@{#317274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1022 lines, -1306 lines) Patch
M net/cookies/canonical_cookie_unittest.cc View 13 chunks +79 lines, -111 lines 0 comments Download
M net/cookies/cookie_monster.h View 7 chunks +10 lines, -11 lines 0 comments Download
M net/cookies/cookie_monster.cc View 73 chunks +231 lines, -287 lines 0 comments Download
M net/cookies/cookie_monster_perftest.cc View 8 chunks +56 lines, -52 lines 0 comments Download
M net/cookies/cookie_monster_store_test.h View 6 chunks +14 lines, -24 lines 0 comments Download
M net/cookies/cookie_monster_store_test.cc View 8 chunks +40 lines, -42 lines 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 87 chunks +465 lines, -683 lines 0 comments Download
M net/cookies/cookie_options.h View 2 chunks +1 line, -5 lines 0 comments Download
M net/cookies/parsed_cookie.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/cookies/parsed_cookie.cc View 10 chunks +23 lines, -22 lines 0 comments Download
M net/cookies/parsed_cookie_unittest.cc View 8 chunks +102 lines, -66 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
erikwright (departed)
Stamp LGTM.
5 years, 10 months ago (2015-02-19 17:51:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929303003/1
5 years, 10 months ago (2015-02-19 17:57:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/3541)
5 years, 10 months ago (2015-02-19 19:13:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929303003/1
5 years, 10 months ago (2015-02-20 07:32:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 08:52:51 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 08:53:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be84af3196d7b6ce5c49c02b2fa47685f8d417c9
Cr-Commit-Position: refs/heads/master@{#317274}

Powered by Google App Engine
This is Rietveld 408576698