Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 929253004: Do not always store media device rejection. (Closed)

Created:
5 years, 10 months ago by perkj_chrome
Modified:
5 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not always store media device rejection. If the security origin of frame is not the same as its ancestors, we don't use preset allow. We should then not sticky store deny either. BUG=456628 Committed: https://crrev.com/4653a504e5da4d71ff5b8193adbf2fc067280ffb Cr-Commit-Position: refs/heads/master@{#318021}

Patch Set 1 #

Patch Set 2 : Renamed SetPermission to StorePersmission. #

Total comments: 2

Patch Set 3 : Fixed spelling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/media/media_stream_devices_controller.h View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
perkj_chrome
Please?
5 years, 10 months ago (2015-02-24 15:55:47 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 10 months ago (2015-02-24 17:35:32 UTC) #3
mcasas
https://codereview.chromium.org/929253004/diff/20001/chrome/browser/media/media_stream_devices_controller.h File chrome/browser/media/media_stream_devices_controller.h (right): https://codereview.chromium.org/929253004/diff/20001/chrome/browser/media/media_stream_devices_controller.h#newcode108 chrome/browser/media/media_stream_devices_controller.h:108: void StorePersmission(bool allowed) const; s/Persmission/Permission/
5 years, 10 months ago (2015-02-24 17:58:10 UTC) #5
perkj_chrome
https://codereview.chromium.org/929253004/diff/20001/chrome/browser/media/media_stream_devices_controller.h File chrome/browser/media/media_stream_devices_controller.h (right): https://codereview.chromium.org/929253004/diff/20001/chrome/browser/media/media_stream_devices_controller.h#newcode108 chrome/browser/media/media_stream_devices_controller.h:108: void StorePersmission(bool allowed) const; On 2015/02/24 17:58:10, mcasas wrote: ...
5 years, 10 months ago (2015-02-25 09:22:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929253004/40001
5 years, 10 months ago (2015-02-25 09:27:39 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-25 10:48:12 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 10:49:32 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4653a504e5da4d71ff5b8193adbf2fc067280ffb
Cr-Commit-Position: refs/heads/master@{#318021}

Powered by Google App Engine
This is Rietveld 408576698