Implement without patch retries and src-side script for webview_licenses.py

Implement without patch retries and src-side script for webview_licenses.py

Run it on Android bots (depends on https://codereview.chromium.org/930233002).

BUG=459147, 422235
R=mnaganov@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/17683f2833916e58261ee2c798bf77357d3e3b28

[Paweł Hajdan Jr., 2015-02-17 10:26:05]

phajdan.jr@chromium.org changed reviewers:
+ torne@chromium.org

[Torne, 2015-02-17 10:45:28]

torne@chromium.org changed reviewers:
+ mnaganov@chromium.org

[mnaganov (inactive), 2015-02-17 11:27:09]

https://codereview.chromium.org/929223002/diff/1/android_webview/tools/webvie...
File android_webview/tools/webview_licenses.py (right):

https://codereview.chromium.org/929223002/diff/1/android_webview/tools/webvie...
android_webview/tools/webview_licenses.py:171: problem_paths =
sorted(set(unknown + missing + stale))
How exactly will this list be used? Will any human be looking at it? If so, I
don't think it is OK to mash all those problems together. Just a list paths with
no indication of what problems they have might be confusing. 

E.g. consider a deleted file which hasn't been removed from the whitelist file.
The path does not exist anymore, so for a human it will not be immediately
obvious what is wrong with it.

[mnaganov (inactive), 2015-02-17 11:28:35]

https://codereview.chromium.org/929223002/diff/1/android_webview/tools/webvie...
File android_webview/tools/webview_licenses.py (right):

https://codereview.chromium.org/929223002/diff/1/android_webview/tools/webvie...
android_webview/tools/webview_licenses.py:171: problem_paths =
sorted(set(unknown + missing + stale))
On 2015/02/17 11:27:09, mnaganov (cr) wrote:
> How exactly will this list be used? Will any human be looking at it? If so, I
> don't think it is OK to mash all those problems together. Just a list paths
with
> no indication of what problems they have might be confusing. 
> 
> E.g. consider a deleted file which hasn't been removed from the whitelist
file.
> The path does not exist anymore, so for a human it will not be immediately
> obvious what is wrong with it.

Looked at the bug -- if it is only for scripts that check the list of problems
with and without the patch, then it is certainly OK. Please confirm that.

[Paweł Hajdan Jr., 2015-02-17 14:09:37]

https://codereview.chromium.org/929223002/diff/1/android_webview/tools/webvie...
File android_webview/tools/webview_licenses.py (right):

https://codereview.chromium.org/929223002/diff/1/android_webview/tools/webvie...
android_webview/tools/webview_licenses.py:171: problem_paths =
sorted(set(unknown + missing + stale))
On 2015/02/17 11:28:35, mnaganov (cr) wrote:
> Looked at the bug -- if it is only for scripts that check the list of problems
> with and without the patch, then it is certainly OK. Please confirm that.

Yes, JSON is for machine-readable processing.

Content intended to be read by people should be just printed to stdout, and the
script already does it.

[mnaganov (inactive), 2015-02-17 14:19:54]

lgtm

[commit-bot: I haz the power, 2015-02-17 15:56:01]

Patchset 1 (id:??) landed as
https://crrev.com/17683f2833916e58261ee2c798bf77357d3e3b28
Cr-Commit-Position: refs/heads/master@{#316580}

[Paweł Hajdan Jr., 2015-02-17 15:56:14]

Committed patchset #1 (id:1) manually as
17683f2833916e58261ee2c798bf77357d3e3b28 (presubmit successful).