Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: public/platform/WebLayerTreeView.h

Issue 929213004: Plumb selection bounds as a single unit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Refactor WebSelection to align with Frame/VisibleSelection Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebLayerTreeView.h
diff --git a/public/platform/WebLayerTreeView.h b/public/platform/WebLayerTreeView.h
index bcc5f1e858d19d0aecc2c98df715b938dc137bec..ccfea5f2aab9de545a387b1a9ae5ecf7fb52cf6c 100644
--- a/public/platform/WebLayerTreeView.h
+++ b/public/platform/WebLayerTreeView.h
@@ -42,6 +42,7 @@ class WebCompositeAndReadbackAsyncCallback;
class WebLayer;
struct WebPoint;
struct WebSelectionBound;
+class WebSelection;
class WebWidget;
class WebLayerTreeView {
@@ -130,10 +131,9 @@ public:
virtual void clearViewportLayers() { }
// Used to update the active selection bounds.
- // If the (empty) selection is an insertion point, |start| and |end| will be identical with type |Caret|.
- // If the (non-empty) selection has mixed RTL/LTR text, |start| and |end| may share the same type,
- // |SelectionLeft| or |SelectionRight|.
+ // FIXME: Remove this overload when downstream consumers have been updated to use WebSelection, crbug.com/466672.
virtual void registerSelection(const WebSelectionBound& start, const WebSelectionBound& end) { }
+ virtual void registerSelection(const WebSelection&) { }
virtual void clearSelection() { }
// Debugging / dangerous ---------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698