Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1925)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 929213004: Plumb selection bounds as a single unit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Refactor WebSelection to align with Frame/VisibleSelection Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 46d8d1aed777ec11ecdd03d89dde44a2acd22cab..1d44c5dcdb12f9baee4f1a2b1a55c6ce2db6a715 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -134,6 +134,7 @@
#include "public/web/WebPlugin.h"
#include "public/web/WebPluginAction.h"
#include "public/web/WebRange.h"
+#include "public/web/WebSelection.h"
#include "public/web/WebTextInputInfo.h"
#include "public/web/WebViewClient.h"
#include "public/web/WebWindowFeatures.h"
@@ -2018,16 +2019,19 @@ void WebViewImpl::exitFullScreenForElement(Element* element)
m_fullscreenController->exitFullScreenForElement(element);
}
-void WebViewImpl::clearCompositedSelectionBounds()
+void WebViewImpl::clearCompositedSelection()
{
if (m_layerTreeView)
m_layerTreeView->clearSelection();
}
-void WebViewImpl::updateCompositedSelectionBounds(const WebSelectionBound& anchor, const WebSelectionBound& focus)
+void WebViewImpl::updateCompositedSelection(const WebSelection& selection)
{
- if (m_layerTreeView)
- m_layerTreeView->registerSelection(anchor, focus);
+ if (m_layerTreeView) {
+ m_layerTreeView->registerSelection(selection);
+ // FIXME: Remove this overload when downstream consumers have been updated, crbug.com/466672.
+ m_layerTreeView->registerSelection(selection.start(), selection.end());
+ }
}
bool WebViewImpl::hasHorizontalScrollbar()

Powered by Google App Engine
This is Rietveld 408576698