Source/core/page/ChromeClient.h - Issue 929213004: Plumb selection bounds as a single unit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/ChromeClient.h

Issue 929213004: Plumb selection bounds as a single unit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Refactor WebSelection to align with Frame/VisibleSelection Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/ChromeClient.h

diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h

index 2a14ea1cf17d637c0985c644c85978492b9ac128..1c355e7296502b8d3637fd898a438944a16745ef 100644

--- a/Source/core/page/ChromeClient.h

+++ b/Source/core/page/ChromeClient.h

@@ -62,7 +62,7 @@ class Page;

class PagePopupDriver;

class PopupMenuClient;

-struct CompositedSelectionBound;

+struct CompositedSelection;

struct DateTimeChooserParameters;

struct FrameLoadRequest;

struct GraphicsDeviceAdapter;

@@ -183,8 +183,8 @@ public:

virtual void enterFullScreenForElement(Element*) { }

virtual void exitFullScreenForElement(Element*) { }

- virtual void clearCompositedSelectionBounds() { }

- virtual void updateCompositedSelectionBounds(const CompositedSelectionBound& anchor, const CompositedSelectionBound& focus) { }

+ virtual void clearCompositedSelection() { }

+ virtual void updateCompositedSelection(const CompositedSelection&) { }

virtual void needTouchEvents(bool) = 0;