Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: Source/core/layout/compositing/CompositedSelectionBounds.h

Issue 929213004: Plumb selection bounds as a single unit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix copyright Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/compositing/CompositedSelectionBounds.h
diff --git a/public/platform/WebImageGenerator.h b/Source/core/layout/compositing/CompositedSelectionBounds.h
similarity index 76%
copy from public/platform/WebImageGenerator.h
copy to Source/core/layout/compositing/CompositedSelectionBounds.h
index bb17f4d6df96a2dcc73efa069d2c6646a2338ab9..b166af0963de60e0ce8539abea731f61aa0cfc28 100644
--- a/public/platform/WebImageGenerator.h
+++ b/Source/core/layout/compositing/CompositedSelectionBounds.h
@@ -28,19 +28,27 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebImageGenerator_h
-#define WebImageGenerator_h
+#ifndef CompositedSelectionBounds_h
+#define CompositedSelectionBounds_h
-#include "WebCommon.h"
-
-class SkData;
-class SkImageGenerator;
+#include "core/layout/compositing/CompositedSelectionBound.h"
+#include "platform/geometry/FloatPoint.h"
+#include "platform/graphics/GraphicsLayer.h"
namespace blink {
-class BLINK_EXPORT WebImageGenerator {
-public:
- static SkImageGenerator* create(SkData*);
+struct CompositedSelectionBounds {
Rick Byers 2015/03/12 19:27:24 can you please add a short comment describing the
jdduke (slow) 2015/03/16 18:15:41 Done.
+
+ CompositedSelectionBounds()
+ : isEditable(false)
+ , isEditableRegionEmpty(false)
+ {
+ }
+
+ CompositedSelectionBound start;
+ CompositedSelectionBound end;
+ bool isEditable;
+ bool isEditableRegionEmpty;
yosin_UTC9 2015/03/13 02:06:37 Q: Could you tell me what "Region" is?
jdduke (slow) 2015/03/16 18:15:41 Sure. In short, we want to know whether we can 1)
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698