Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: public/platform/WebSelectionBound.h

Issue 929213004: Plumb selection bounds as a single unit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebSelectionBound.h
diff --git a/public/platform/WebSelectionBound.h b/public/platform/WebSelectionBound.h
index bdedd3636e685e4a8cff8b5c1e863b384057f490..466a39cc0a08eee6e3f6590858c46199a8956884 100644
--- a/public/platform/WebSelectionBound.h
+++ b/public/platform/WebSelectionBound.h
@@ -11,6 +11,8 @@ namespace blink {
// An endpoint for an active selection region.
struct WebSelectionBound {
+ // TODO(jdduke): Remove this logic when downstream code adopts
+ // |WebSelection| for determining bound orientation.
enum Type {
Caret,
SelectionLeft,
@@ -20,6 +22,7 @@ struct WebSelectionBound {
explicit WebSelectionBound(Type type)
: type(type)
, layerId(0)
+ , isTextDirectionRTL(false)
{
}
@@ -34,6 +37,9 @@ struct WebSelectionBound {
// that define the selection bound.
WebPoint edgeTopInLayer;
WebPoint edgeBottomInLayer;
+
+ // Whether the text direction at this location is RTL.
+ bool isTextDirectionRTL;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698