public/platform/WebLayerTreeView.h - Issue 929213004: Plumb selection bounds as a single unit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebLayerTreeView.h

Issue 929213004: Plumb selection bounds as a single unit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: public/platform/WebLayerTreeView.h

diff --git a/public/platform/WebLayerTreeView.h b/public/platform/WebLayerTreeView.h

index d268c96e157089748982ff9a6d5868c00069a1cb..14895ee7b4aab37c4836c9a4766270f723631669 100644

--- a/public/platform/WebLayerTreeView.h

+++ b/public/platform/WebLayerTreeView.h

@@ -124,7 +124,9 @@ public:

// If the (empty) selection is an insertion point, |start| and |end| will be identical with type |Caret|.

// If the (non-empty) selection has mixed RTL/LTR text, |start| and |end| may share the same type,

// |SelectionLeft| or |SelectionRight|.

+ // TOOD(jdduke): Remove this function when downstream consumers have been updated to use WebSelectionBounds.

virtual void registerSelection(const WebSelectionBound& start, const WebSelectionBound& end) { }

+ virtual void registerSelection(const WebSelectionBounds& bounds) { registerSelection(bounds.start, bounds.end); }

virtual void clearSelection() { }

// Debugging / dangerous ---------------------------------------------