Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: Source/web/WebViewImpl.cpp

Issue 929213004: Plumb selection bounds as a single unit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: TODO Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 #include "public/web/WebAutofillClient.h" 127 #include "public/web/WebAutofillClient.h"
128 #include "public/web/WebBeginFrameArgs.h" 128 #include "public/web/WebBeginFrameArgs.h"
129 #include "public/web/WebFrameClient.h" 129 #include "public/web/WebFrameClient.h"
130 #include "public/web/WebHitTestResult.h" 130 #include "public/web/WebHitTestResult.h"
131 #include "public/web/WebInputElement.h" 131 #include "public/web/WebInputElement.h"
132 #include "public/web/WebMediaPlayerAction.h" 132 #include "public/web/WebMediaPlayerAction.h"
133 #include "public/web/WebNode.h" 133 #include "public/web/WebNode.h"
134 #include "public/web/WebPlugin.h" 134 #include "public/web/WebPlugin.h"
135 #include "public/web/WebPluginAction.h" 135 #include "public/web/WebPluginAction.h"
136 #include "public/web/WebRange.h" 136 #include "public/web/WebRange.h"
137 #include "public/web/WebSelection.h"
137 #include "public/web/WebTextInputInfo.h" 138 #include "public/web/WebTextInputInfo.h"
138 #include "public/web/WebViewClient.h" 139 #include "public/web/WebViewClient.h"
139 #include "public/web/WebWindowFeatures.h" 140 #include "public/web/WebWindowFeatures.h"
140 #include "web/CompositionUnderlineVectorBuilder.h" 141 #include "web/CompositionUnderlineVectorBuilder.h"
141 #include "web/ContextFeaturesClientImpl.h" 142 #include "web/ContextFeaturesClientImpl.h"
142 #include "web/DatabaseClientImpl.h" 143 #include "web/DatabaseClientImpl.h"
143 #include "web/DevToolsEmulator.h" 144 #include "web/DevToolsEmulator.h"
144 #include "web/FullscreenController.h" 145 #include "web/FullscreenController.h"
145 #include "web/GraphicsLayerFactoryChromium.h" 146 #include "web/GraphicsLayerFactoryChromium.h"
146 #include "web/InspectorOverlayImpl.h" 147 #include "web/InspectorOverlayImpl.h"
(...skipping 1842 matching lines...) Expand 10 before | Expand all | Expand 10 after
1989 void WebViewImpl::enterFullScreenForElement(Element* element) 1990 void WebViewImpl::enterFullScreenForElement(Element* element)
1990 { 1991 {
1991 m_fullscreenController->enterFullScreenForElement(element); 1992 m_fullscreenController->enterFullScreenForElement(element);
1992 } 1993 }
1993 1994
1994 void WebViewImpl::exitFullScreenForElement(Element* element) 1995 void WebViewImpl::exitFullScreenForElement(Element* element)
1995 { 1996 {
1996 m_fullscreenController->exitFullScreenForElement(element); 1997 m_fullscreenController->exitFullScreenForElement(element);
1997 } 1998 }
1998 1999
1999 void WebViewImpl::clearCompositedSelectionBounds() 2000 void WebViewImpl::clearCompositedSelection()
2000 { 2001 {
2001 if (m_layerTreeView) 2002 if (m_layerTreeView)
2002 m_layerTreeView->clearSelection(); 2003 m_layerTreeView->clearSelection();
2003 } 2004 }
2004 2005
2005 void WebViewImpl::updateCompositedSelectionBounds(const WebSelectionBound& ancho r, const WebSelectionBound& focus) 2006 void WebViewImpl::updateCompositedSelection(const WebSelection& selection)
2006 { 2007 {
2007 if (m_layerTreeView) 2008 if (m_layerTreeView) {
2008 m_layerTreeView->registerSelection(anchor, focus); 2009 m_layerTreeView->registerSelection(selection);
2010 // TODO(jdduke): Remove this overload when downstream consumers have bee n updated, crbug.com/466672.
2011 m_layerTreeView->registerSelection(selection.start(), selection.end());
2012 }
2009 } 2013 }
2010 2014
2011 bool WebViewImpl::hasHorizontalScrollbar() 2015 bool WebViewImpl::hasHorizontalScrollbar()
2012 { 2016 {
2013 return mainFrameImpl()->frameView()->horizontalScrollbar(); 2017 return mainFrameImpl()->frameView()->horizontalScrollbar();
2014 } 2018 }
2015 2019
2016 bool WebViewImpl::hasVerticalScrollbar() 2020 bool WebViewImpl::hasVerticalScrollbar()
2017 { 2021 {
2018 return mainFrameImpl()->frameView()->verticalScrollbar(); 2022 return mainFrameImpl()->frameView()->verticalScrollbar();
(...skipping 2482 matching lines...) Expand 10 before | Expand all | Expand 10 after
4501 return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width 4505 return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width
4502 || (constraints.minimumScale == constraints.maximumScale && constraints. minimumScale != -1); 4506 || (constraints.minimumScale == constraints.maximumScale && constraints. minimumScale != -1);
4503 } 4507 }
4504 4508
4505 void WebViewImpl::forceNextWebGLContextCreationToFail() 4509 void WebViewImpl::forceNextWebGLContextCreationToFail()
4506 { 4510 {
4507 WebGLRenderingContext::forceNextWebGLContextCreationToFail(); 4511 WebGLRenderingContext::forceNextWebGLContextCreationToFail();
4508 } 4512 }
4509 4513
4510 } // namespace blink 4514 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698