Plumb selection bounds as a single unit

Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 96 matching lines @@
 
 namespace blink {
 
 // Converts a AXObjectCache::AXNotification to a WebAXEvent
 static WebAXEvent toWebAXEvent(AXObjectCache::AXNotification notification)
 {
     // These enums have the same values; enforced in AssertMatchingEnums.cpp.
     return static_cast<WebAXEvent>(notification);
 }
 
-static WebSelectionBound toWebSelectionBound(const CompositedSelectionBound& bound)
+static WebSelectionBounds toWebSelectionBounds(const CompositedSelectionBounds& bound)

[mfomitchev, 2015/02/17 22:25:51]

This doesn't need to be changed, right?

[jdduke (slow), 2015/02/17 22:28:50]

Oops, yeah this was a typo, I never actually compiled it =/

 {
     ASSERT(bound.layer);
 
     // These enums have the same values; enforced in AssertMatchingEnums.cpp.
     WebSelectionBound result(static_cast<WebSelectionBound::Type>(bound.type));
     result.layerId = bound.layer->platformLayer()->id();
     result.edgeTopInLayer = roundedIntPoint(bound.edgeTopInLayer);
     result.edgeBottomInLayer = roundedIntPoint(bound.edgeBottomInLayer);
     return result;
 }
 
+static WebSelectionBounds toWebSelectionBounds(const CompositedSelectionBounds& bounds)
+{
+    WebSelectionBounds result(toWebSelectionBound(bounds.start), toWebSelectionBound(bounds.end));
+    result.length = bounds.length;
+    result.isEditable = bounds.isEditable;
+    result.isUserTriggered = bounds.isUserTriggered;
+    return result;
+}
+
 ChromeClientImpl::ChromeClientImpl(WebViewImpl* webView)
     : m_webView(webView)
 {
 }
 
 ChromeClientImpl::~ChromeClientImpl()
 {
 }
 
 void* ChromeClientImpl::webView() const
@@ skipping 588 matching lines @@
 void ChromeClientImpl::exitFullScreenForElement(Element* element)
 {
     m_webView->exitFullScreenForElement(element);
 }
 
 void ChromeClientImpl::clearCompositedSelectionBounds()
 {
     m_webView->clearCompositedSelectionBounds();
 }
 
-void ChromeClientImpl::updateCompositedSelectionBounds(const CompositedSelectionBound& anchor, const CompositedSelectionBound& focus)
+void ChromeClientImpl::updateCompositedSelectionBounds(const CompositedSelectionBounds& bounds)
 {
-    m_webView->updateCompositedSelectionBounds(toWebSelectionBound(anchor), toWebSelectionBound(focus));
+    m_webView->updateCompositedSelectionBounds(toWebSelectionBounds(anchor));

[mfomitchev, 2015/02/17 22:25:51]

anchor -> bounds

 }
 
 bool ChromeClientImpl::hasOpenedPopup() const
 {
     return m_webView->hasOpenedPopup();
 }
 
 PassRefPtrWillBeRawPtr<PopupMenu> ChromeClientImpl::createPopupMenu(LocalFrame& frame, PopupMenuClient* client)
 {
     if (WebViewImpl::useExternalPopupMenus())
@@ skipping 140 matching lines @@
         webframe->autofillClient()->dataListOptionsChanged(WebInputElement(&input));
 }
 
 void ChromeClientImpl::registerViewportLayers() const
 {
     if (m_webView->rootGraphicsLayer() && m_webView->layerTreeView() && m_webView->pinchVirtualViewportEnabled())
         m_webView->page()->frameHost().pinchViewport().registerLayersWithTreeView(m_webView->layerTreeView());
 }
 
 } // namespace blink