Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 929163002: Change bookmark app menu from Add to Dock... to Add to Applications... (Closed)

Created:
5 years, 10 months ago by benwells
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, jackhou1
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change bookmark app menu from Add to Dock... to Add to Applications... As the app is not added to the dock the current name is misleading. BUG=459082 Committed: https://crrev.com/cd5910ec61c424fd0f719a2e7d53241e8d617e5d Cr-Commit-Position: refs/heads/master@{#316676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
benwells
5 years, 10 months ago (2015-02-17 01:50:13 UTC) #2
jackhou1
lgtm
5 years, 10 months ago (2015-02-17 03:24:23 UTC) #3
benwells
+thestig for owners review. hopefully this is an easy one...
5 years, 10 months ago (2015-02-17 03:32:31 UTC) #5
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-17 19:57:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929163002/1
5 years, 10 months ago (2015-02-17 19:58:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/2499)
5 years, 10 months ago (2015-02-17 20:58:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929163002/1
5 years, 10 months ago (2015-02-17 22:08:20 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 22:33:23 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:34:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd5910ec61c424fd0f719a2e7d53241e8d617e5d
Cr-Commit-Position: refs/heads/master@{#316676}

Powered by Google App Engine
This is Rietveld 408576698