Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: Source/core/dom/ScriptedAnimationController.h

Issue 92913002: Manage RequestAnimationFrameCallbacks with OwnPtrs instead of RefPtrs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/RequestAnimationFrameCallback.h ('k') | Source/core/dom/ScriptedAnimationController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ScriptedAnimationController.h
diff --git a/Source/core/dom/ScriptedAnimationController.h b/Source/core/dom/ScriptedAnimationController.h
index 7c83094406d09625486bb0e4c71247f141482873..5f7efb887e9cc96ebe8810b48d59ff1d548bc853 100644
--- a/Source/core/dom/ScriptedAnimationController.h
+++ b/Source/core/dom/ScriptedAnimationController.h
@@ -50,7 +50,7 @@ public:
typedef int CallbackId;
- int registerCallback(PassRefPtr<RequestAnimationFrameCallback>);
+ int registerCallback(PassOwnPtr<RequestAnimationFrameCallback>);
void cancelCallback(CallbackId);
void serviceScriptedAnimations(double monotonicTimeNow);
@@ -68,8 +68,9 @@ private:
void dispatchEvents();
void executeCallbacks(double monotonicTimeNow);
- typedef Vector<RefPtr<RequestAnimationFrameCallback> > CallbackList;
+ typedef Vector<OwnPtr<RequestAnimationFrameCallback> > CallbackList;
CallbackList m_callbacks;
+ CallbackList m_callbacksToInvoke; // only non-empty while inside executeCallbacks
Document* m_document;
CallbackId m_nextCallbackId;
« no previous file with comments | « Source/core/dom/RequestAnimationFrameCallback.h ('k') | Source/core/dom/ScriptedAnimationController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698