Issue 92913002: Manage RequestAnimationFrameCallbacks with OwnPtrs instead of RefPtrs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92913002: Manage RequestAnimationFrameCallbacks with OwnPtrs instead of RefPtrs (Closed)

Created:
7 years ago by adamk

Modified:
7 years ago

Reviewers:
jamesr, abarth-chromium

CC:
blink-reviews, shans, eae+blinkwatch, adamk+blink_chromium.org, Steve Block, dino_apple.com, Nils Barth (inactive), Nate Chapin, arv+blink, alancutter (OOO until 2018), marja+watch_chromium.org, dglazkov+blink, abarth-chromium, dstockwell, Timothy Loh, Eric Willigers, rjwright, darktears, haraken, kojih, jsbell+bindings_chromium.org, Mike Lawther (Google), Inactive, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Manage RequestAnimationFrameCallbacks with OwnPtrs instead of RefPtrs Blink now prefers non-refcounted IDL callbacks. RAF slightly abused the refcounted-ness of its callback, which this patch takes care of removing. It also allows simplifies the m_firedOrCancelled member to just m_cancelled. R=jamesr@chromium.org BUG=323681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163026

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -29 lines)			Patch
M	Source/bindings/scripts/code_generator_v8.pm	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/Document.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/RequestAnimationFrameCallback.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	Source/core/dom/ScriptedAnimationController.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/dom/ScriptedAnimationController.cpp	View	4 chunks	+16 lines, -15 lines	0 comments	Download
M	Source/core/frame/DOMWindow.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/frame/DOMWindow.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/92913002/1

7 years ago (2013-12-02 19:29:46 UTC) #3

Message was sent while issue was closed.

Change committed as 163026

Expand Messages | Collapse Messages