Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 929123002: Move DeadControl into the JSGraph so that it can be reused. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.h ('k') | src/compiler/control-reducer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 277f0d5c8598a6a1822a9eaa17a92875c12e2069..2680fc620a61211364758390f78e2847a26dbb50 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -2970,9 +2970,9 @@ Node* AstGraphBuilder::MakeNode(const Operator* op, int value_input_count,
}
if (has_framestate) {
// The frame state will be inserted later. Here we misuse
- // the dead_control node as a sentinel to be later overwritten
+ // the {DeadControl} node as a sentinel to be later overwritten
// with the real frame state.
- *current_input++ = dead_control();
+ *current_input++ = jsgraph()->DeadControl();
}
if (has_effect) {
*current_input++ = environment_->GetEffectDependency();
@@ -3157,16 +3157,6 @@ Node* AstGraphBuilder::MergeValue(Node* value, Node* other, Node* control) {
return value;
}
-
-Node* AstGraphBuilder::dead_control() {
- if (!dead_control_.is_set()) {
- Node* dead_node = graph()->NewNode(common()->Dead());
- dead_control_.set(dead_node);
- return dead_node;
- }
- return dead_control_.get();
-}
-
} // namespace compiler
} // namespace internal
} // namespace v8
« no previous file with comments | « src/compiler/ast-graph-builder.h ('k') | src/compiler/control-reducer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698