content/browser/renderer_host/web_input_event_aura_unittest.cc - Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/web_input_event_aura_unittest.cc

Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup of the dom_key.h Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/event_sender.cc ('K') | « content/browser/renderer_host/web_input_event_aura.cc ('k') | content/child/blink_platform_impl.h » ('j') | content/child/blink_platform_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/web_input_event_aura_unittest.cc

diff --git a/content/browser/renderer_host/web_input_event_aura_unittest.cc b/content/browser/renderer_host/web_input_event_aura_unittest.cc

index 9f0cf473a73395a72dcaaa54bfd04eb98f38763e..f20e82b01450651089e840ed620cf10a93c9e080 100644

--- a/content/browser/renderer_host/web_input_event_aura_unittest.cc

+++ b/content/browser/renderer_host/web_input_event_aura_unittest.cc

@@ -34,6 +34,8 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) {

webkit_event.modifiers);

EXPECT_EQ(static_cast<int>(ui::DomCode::CONTROL_LEFT),

webkit_event.domCode);

+ EXPECT_EQ(static_cast<int>(ui::DomKey::CONTROL),

+ webkit_event.domKey);

}

{

// Release Ctrl.

@@ -44,6 +46,9 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) {

EXPECT_EQ(blink::WebInputEvent::IsLeft, webkit_event.modifiers);

EXPECT_EQ(static_cast<int>(ui::DomCode::CONTROL_LEFT),

webkit_event.domCode);

+ EXPECT_EQ(static_cast<int>(ui::DomKey::CONTROL),

+ webkit_event.domKey);

}

#if defined(USE_X11)

const int kLocationModifiers =