Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: content/browser/renderer_host/web_input_event_aura_unittest.cc

Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: UnitTest updated as MakeKeyboardEvent now adds a value to differentiate Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/web_input_event_aura_unittest.cc
diff --git a/content/browser/renderer_host/web_input_event_aura_unittest.cc b/content/browser/renderer_host/web_input_event_aura_unittest.cc
index 9f0cf473a73395a72dcaaa54bfd04eb98f38763e..79e942d08dc22d8d2fcaa24f2dfee8574af1ded7 100644
--- a/content/browser/renderer_host/web_input_event_aura_unittest.cc
+++ b/content/browser/renderer_host/web_input_event_aura_unittest.cc
@@ -34,6 +34,8 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) {
webkit_event.modifiers);
EXPECT_EQ(static_cast<int>(ui::DomCode::CONTROL_LEFT),
webkit_event.domCode);
+ EXPECT_EQ(static_cast<int>(ui::DomKey::CONTROL),
+ webkit_event.domKey - DOM_KEY_PRINT_NON_DIFF);
Wez 2015/07/25 23:12:26 As noted as per Kevin's request - if the DomKey va
Habib Virji 2015/07/31 16:17:29 Done.
}
{
// Release Ctrl.
@@ -44,6 +46,9 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) {
EXPECT_EQ(blink::WebInputEvent::IsLeft, webkit_event.modifiers);
EXPECT_EQ(static_cast<int>(ui::DomCode::CONTROL_LEFT),
webkit_event.domCode);
+ EXPECT_EQ(static_cast<int>(ui::DomKey::CONTROL),
+ webkit_event.domKey - DOM_KEY_PRINT_NON_DIFF);
+
}
#if defined(USE_X11)
const int kLocationModifiers =

Powered by Google App Engine
This is Rietveld 408576698