Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: ui/events/event.cc

Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "API has been updated on the blink side" Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/event.cc
diff --git a/ui/events/event.cc b/ui/events/event.cc
index 5e7d8c86377a4d6a7c5546dcde02b6a76e6c71d4..c8b733d933a400369c020748765fc4480be64cd1 100644
--- a/ui/events/event.cc
+++ b/ui/events/event.cc
@@ -788,7 +788,7 @@ void KeyEvent::ApplyLayout() const {
character_ = (IsControlDown() || !native_event()) ?
GetCharacterFromKeyCode(key_code_, flags()) :
GetCharacterFromXEvent(native_event());
- // TODO(kpschoedel): set key_ field for X11.
+ GetMeaningFromKeyCode(key_code_, flags(), &key_, &character_);
Wez 2015/04/21 02:25:58 Not sure what you're trying to do here. GetMeaning
Habib Virji 2015/04/29 16:05:18 There was a following CL: 954943003 that was tryin
#elif defined(USE_OZONE)
KeyboardCode key_code;
if (!KeyboardLayoutEngineManager::GetKeyboardLayoutEngine()->Lookup(

Powered by Google App Engine
This is Rietveld 408576698