Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: ui/events/event.cc

Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/test_runner/event_sender.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event.cc
diff --git a/ui/events/event.cc b/ui/events/event.cc
index c26b9c97b7748719a0cff3dee816b32912524dff..4330e544a06ff7a512d3588ef00f048de27b430b 100644
--- a/ui/events/event.cc
+++ b/ui/events/event.cc
@@ -782,7 +782,7 @@ void KeyEvent::ApplyLayout() const {
character_ = (IsControlDown() || !native_event()) ?
GetCharacterFromKeyCode(key_code_, flags()) :
GetCharacterFromXEvent(native_event());
- // TODO(kpschoedel): set key_ field for X11.
+ GetMeaningFromKeyCode(key_code_, flags(), &key_, &character_);
Wez 2015/02/20 00:00:30 GetMeaningFromKeyCode currently assumes a US Engli
Habib Virji 2015/02/23 10:10:05 I have started looking into enabling |key| attribu
#elif defined(USE_OZONE)
KeyboardCode key_code;
if (!KeyboardLayoutEngineManager::GetKeyboardLayoutEngine()->Lookup(
« no previous file with comments | « content/shell/renderer/test_runner/event_sender.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698