[KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings

content/browser/renderer_host/web_input_event_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/web_input_event_aura.h"
 
 #include "content/browser/renderer_host/input/web_input_event_util.h"
 #include "content/browser/renderer_host/ui_events_helper.h"
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/aura/window.h"
@@ skipping 54 matching lines @@
       NOTREACHED();
   }
 
   if (webkit_event.modifiers & blink::WebInputEvent::AltKey)
     webkit_event.isSystemKey = true;
 
   webkit_event.windowsKeyCode = event.GetLocatedWindowsKeyboardCode();
   webkit_event.nativeKeyCode =
     ui::KeycodeConverter::DomCodeToNativeKeycode(event.code());
   webkit_event.domCode = static_cast<int>(event.code());
+  webkit_event.domKey = static_cast<int>(event.GetDomKey());

[Wez, 2015/05/07 00:23:22]

You also need to propagate the ui::KeyEvent::character_ value into the
WebKeyboardEvent, to cope with printable DOM |key| values, since the DomKey enum
only deals with non-printable keys.

[Habib Virji, 2015/05/19 16:16:28]

It is already covered in the below unmodifiedText as GetUnmodifiedText in turns
call GetCharacter(). 

[kpschoedel, 2015/05/19 20:00:26]

You'll also need to set .domKey in the OS_WIN case of MakeWebKeyboardEvent()
below. (Look for the .domCode after you rebase.) Also add to  
WebInputEventAuraTest.TestMakeWebKeyboardEvent in
content/browser/renderer_host/web_input_event_aura_unittest.cc (again, look for
.domCode there).

[Habib Virji, 2015/05/21 16:36:09]

Done.

[Wez, 2015/06/03 00:35:08]

unmodifiedText is an old field in WebKit keyboard events - it has nothing to do
with the new |key| specification, and is only valid on |keypress| (i.e.
character) events, in general.

[Habib Virji, 2015/06/05 20:05:11]

In GetUnmodifiedText it does not check the |keypress| event.  
https://code.google.com/p/chromium/codesearch#chromium/src/ui/events/event.cc...

[Wez, 2015/06/11 00:09:05]

No, but the GetCharacter() function that it delegates to returns |character_|,
which is not set for non-keypress events under Windows.

[Habib Virji, 2015/06/24 14:32:12]

Acknowledged.

   webkit_event.unmodifiedText[0] = event.GetUnmodifiedText();
   webkit_event.text[0] = event.GetText();
 
   webkit_event.setKeyIdentifierFromWindowsKeyCode();
 
   return webkit_event;
 }
 
 blink::WebMouseWheelEvent MakeWebMouseWheelEventFromAuraEvent(
     const ui::ScrollEvent& event) {
@@ skipping 294 matching lines @@
     webkit_event.deltaY = event.y_offset();
   }
 
   webkit_event.wheelTicksX = webkit_event.deltaX / kPixelsPerTick;
   webkit_event.wheelTicksY = webkit_event.deltaY / kPixelsPerTick;
 
   return webkit_event;
 }
 
 }  // namespace content