[KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings

content/child/blink_platform_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/blink_platform_impl.h"
 
 #include <math.h>
 
 #include <vector>
 
@@ skipping 54 matching lines @@
 #include "third_party/WebKit/public/platform/WebConvertableToTraceFormat.h"
 #include "third_party/WebKit/public/platform/WebData.h"
 #include "third_party/WebKit/public/platform/WebFloatPoint.h"
 #include "third_party/WebKit/public/platform/WebMemoryDumpProvider.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebURL.h"
 #include "third_party/WebKit/public/platform/WebWaitableEvent.h"
 #include "third_party/WebKit/public/web/WebSecurityOrigin.h"
 #include "ui/base/layout.h"
 #include "ui/events/gestures/blink/web_gesture_curve_impl.h"
+#include "ui/events/keycodes/dom/dom_key.h"
 #include "ui/events/keycodes/dom/keycode_converter.h"
 
 using blink::WebData;
 using blink::WebFallbackThemeEngine;
 using blink::WebLocalizedString;
 using blink::WebString;
 using blink::WebThemeEngine;
 using blink::WebURL;
 using blink::WebURLError;
 using blink::WebURLLoader;
@@ skipping 1278 matching lines @@
 WebString BlinkPlatformImpl::domCodeStringFromEnum(int dom_code) {
   return WebString::fromUTF8(ui::KeycodeConverter::DomCodeToCodeString(
       static_cast<ui::DomCode>(dom_code)));
 }
 
 int BlinkPlatformImpl::domEnumFromCodeString(const WebString& code) {
   return static_cast<int>(ui::KeycodeConverter::CodeStringToDomCode(
       code.utf8().data()));
 }
 
+WebString BlinkPlatformImpl::domKeyStringFromEnum(int dom_key) {
+  if (dom_key < static_cast<int>(ui::DomKey::CHARACTER)) {
+    return WebString::fromUTF8(ui::KeycodeConverter::DomKeyToKeyString(
+        static_cast<ui::DomKey>(dom_key)));

[dtapuska, 2015/08/13 13:36:47]

This cast is undefined when dom_key is less than 0. Any idea why we didn't add
dom_key as a uint?

In understand this is a virtual specified in the blink API; I'm just commenting
how I would have written it.

+  } else {
+    std::string dom_key_char = base::StringPrintf("%c",

[dtapuska, 2015/08/13 13:36:47]

Does StringPrintf work for unicode characters? ie; I don't believe it does an
int -> utf8 conversion.

I could be wrong; but I tried it in content_shell and it prints out the
incorrect value for non-ascii values.

+        (dom_key - static_cast<int>(ui::DomKey::CHARACTER)));
+    return WebString::fromUTF8(dom_key_char);
+  }
+}
+
+int BlinkPlatformImpl::domKeyEnumFromString(const WebString& key) {
+  ui::DomKey dom_key = ui::KeycodeConverter::KeyStringToDomKey(
+      key.utf8().data());
+  if (dom_key == ui::DomKey::CHARACTER) {
+    int dom_char;
+    base::StringToInt(key.utf8().data(), &dom_char);

[dtapuska, 2015/08/13 13:36:48]

Can we add an ASSERT that this doesn't fail?

+    return dom_char + static_cast<int>(ui::DomKey::CHARACTER);
+  } else {
+    return static_cast<int>(dom_key);
+  }
+}
+
 }  // namespace content