[KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings

content/child/blink_platform_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/blink_platform_impl.h"
 
 #include <math.h>
 
 #include <vector>
 
@@ skipping 1257 matching lines @@
 WebString BlinkPlatformImpl::domCodeStringFromEnum(int dom_code) {
   return WebString::fromUTF8(ui::KeycodeConverter::DomCodeToCodeString(
       static_cast<ui::DomCode>(dom_code)));
 }
 
 int BlinkPlatformImpl::domEnumFromCodeString(const WebString& code) {
   return static_cast<int>(ui::KeycodeConverter::CodeStringToDomCode(
       code.utf8().data()));
 }
 
+WebString BlinkPlatformImpl::domKeyStringFromEnum(int dom_key) {
+  return WebString::fromUTF8(ui::KeycodeConverter::DomKeyToKeyString(
+      static_cast<ui::DomKey>(dom_key)));

[Wez, 2015/04/21 02:25:58]

nit: Strictly speaking the behaviour of static_cast<enum> is undefined if you
pass in an int value that is not a valid enum value, IIRC; we seem to be doing
the same thing above for domCodeStringFromEnum, though, and these should always
be values that we provided in the first place, so shouldn't be a problem.

[Habib Virji, 2015/04/29 16:05:18]

Right wez,this issue was discussed in domCodeString case too and the conclusion
was as you stated above, since the value here are sent by the embedder API. It
should be okay.

+}
+
+int BlinkPlatformImpl::domKeyEnumFromString(const WebString& key) {
+  return static_cast<int>(ui::KeycodeConverter::KeyStringToDomKey(
+      key.utf8().data()));
+}
+
 }  // namespace content