android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java - Issue 92903003: aw: Limit full url href hittest to only anchor type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java

Issue 92903003: aw: Limit full url href hittest to only anchor type (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix SRC_IMAGE_LINK_TYPE as well Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/renderer/aw_render_view_ext.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java

index 45c4aff1ec6cb5aba840ac4710d5fca30c1b8993..3998d725494b09c4faf2d060558d4113a6542d37 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java

@@ -18,6 +18,9 @@ import org.chromium.net.test.util.TestWebServer;

import java.util.concurrent.Callable;

+/**

+ * Test for getHitTestResult, requestFocusNodeHref, and requestImageRef methods

+ */

public class WebKitHitTestTest extends AwTestBase {

private TestAwContentsClient mContentsClient;

private AwTestContainerView mTestView;

@@ -153,7 +156,7 @@ public class WebKitHitTestTest extends AwTestBase {

simulateInput(byTouch);

assertTrue(pollForHitTestDataOnUiThread(

HitTestResult.SRC_ANCHOR_TYPE, fullpath));

- assertTrue(pollForHrefAndImageSrcOnUiThread(null, ANCHOR_TEXT, null));

+ assertTrue(pollForHrefAndImageSrcOnUiThread(fullpath, ANCHOR_TEXT, null));

}

@SmallTest

@@ -176,7 +179,7 @@ public class WebKitHitTestTest extends AwTestBase {

simulateInput(byTouch);

assertTrue(pollForHitTestDataOnUiThread(

HitTestResult.SRC_ANCHOR_TYPE, fullpath));

- assertTrue(pollForHrefAndImageSrcOnUiThread(relpath, ANCHOR_TEXT, null));

+ assertTrue(pollForHrefAndImageSrcOnUiThread(fullpath, ANCHOR_TEXT, null));

}

@SmallTest