Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 928973002: Add mouseLeave API in eventSender. (Closed)

Created:
5 years, 10 months ago by Miyoung Shin
Modified:
5 years, 9 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mouseLeave API in eventSender. This patch makes the test can trigger a mouseLeave event. BUG=450631 R=rbyers@chromium.org Committed: https://crrev.com/12c7fea23d6077af7d6a2ea6f8fc4680cfaf23d1 Cr-Commit-Position: refs/heads/master@{#319393}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M content/shell/renderer/test_runner/event_sender.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 1 4 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (1 generated)
Miyoung Shin
@rbyers, PTAL. I verified it by the test uloaded at http://crrev.com/930803002 [1]. After merging this ...
5 years, 10 months ago (2015-02-16 07:42:08 UTC) #1
Rick Byers
On 2015/02/16 07:42:08, Miyoung Shin wrote: > @rbyers, PTAL. > > I verified it by ...
5 years, 10 months ago (2015-02-20 20:48:54 UTC) #2
Miyoung Shin
Thank you for your kind comment. I might miss the point you asked. I uploaded ...
5 years, 10 months ago (2015-02-23 02:38:37 UTC) #3
Miyoung Shin
On 2015/02/23 02:38:37, Miyoung Shin wrote: > Thank you for your kind comment. > I ...
5 years, 9 months ago (2015-03-05 04:59:06 UTC) #4
Rick Byers
LGTM
5 years, 9 months ago (2015-03-05 14:42:06 UTC) #5
Rick Byers
On 2015/03/05 14:42:06, Rick Byers wrote: > LGTM I kicked off a couple blink tryjobs ...
5 years, 9 months ago (2015-03-05 14:43:50 UTC) #6
Miyoung Shin
On 2015/03/05 14:43:50, Rick Byers wrote: > On 2015/03/05 14:42:06, Rick Byers wrote: > > ...
5 years, 9 months ago (2015-03-06 01:02:39 UTC) #7
Rick Byers
On 2015/03/06 01:02:39, Miyoung Shin wrote: > On 2015/03/05 14:43:50, Rick Byers wrote: > > ...
5 years, 9 months ago (2015-03-06 01:08:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928973002/20001
5 years, 9 months ago (2015-03-06 01:58:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-06 02:31:36 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 02:32:41 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12c7fea23d6077af7d6a2ea6f8fc4680cfaf23d1
Cr-Commit-Position: refs/heads/master@{#319393}

Powered by Google App Engine
This is Rietveld 408576698