sandbox: use waitpid consistently

sandbox: use waitpid consistently

The BMM PNaCl toolchain doesn't currently support waitid.  Arguably it
should because it's in POSIX, but the userland/Linux signal ABI
mismatch makes it non-trivial because of the siginfo_t.  Since we
don't need the siginfo_t anyway, we can just use waitpid instead.

While here, use WIFEXITED and WEXITSTATUS for interpreting status
instead of directly comparing it to the expected exit code.

Committed: https://crrev.com/b71febc45698e4cae48c92c7a99d235da41adb55
Cr-Commit-Position: refs/heads/master@{#317080}

[mdempsky, 2015-02-19 01:46:18]

mdempsky@chromium.org changed reviewers:
+ jln@chromium.org, rickyz@chromium.org

[rickyz (no longer on Chrome), 2015-02-19 01:47:50]

lgtm

[mdempsky, 2015-02-19 02:07:57]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2015-02-19 02:09:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/928963003/1

[commit-bot: I haz the power, 2015-02-19 02:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-19 02:09:40]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jln (very slow on Chromium), 2015-02-19 03:59:59]

lgtm

https://codereview.chromium.org/928963003/diff/1/sandbox/linux/services/crede...
File sandbox/linux/services/credentials.cc (right):

https://codereview.chromium.org/928963003/diff/1/sandbox/linux/services/crede...
sandbox/linux/services/credentials.cc:117: return WIFEXITED(status) &&
WEXITSTATUS(status) == kExitSuccess;
ugh, thanks :/

https://codereview.chromium.org/928963003/diff/1/sandbox/linux/services/crede...
sandbox/linux/services/credentials.cc:184: CHECK_EQ(0, WEXITSTATUS(status));
Since you're now checking the exit code, do you want to use kExitSuccess here
and in _exit() above?

[mdempsky, 2015-02-19 04:02:15]

New patchsets have been uploaded after l-g-t-m from
rickyz@chromium.org,jln@chromium.org

[mdempsky, 2015-02-19 04:02:51]

https://codereview.chromium.org/928963003/diff/1/sandbox/linux/services/crede...
File sandbox/linux/services/credentials.cc (right):

https://codereview.chromium.org/928963003/diff/1/sandbox/linux/services/crede...
sandbox/linux/services/credentials.cc:184: CHECK_EQ(0, WEXITSTATUS(status));
On 2015/02/19 03:59:59, jln wrote:
> Since you're now checking the exit code, do you want to use kExitSuccess here
> and in _exit() above?

Done.

[mdempsky, 2015-02-19 04:02:54]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2015-02-19 04:03:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/928963003/20001

[commit-bot: I haz the power, 2015-02-19 05:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-19 05:23:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mdempsky, 2015-02-19 05:24:16]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2015-02-19 05:25:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/928963003/20001

[commit-bot: I haz the power, 2015-02-19 06:29:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-19 06:29:35]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mdempsky, 2015-02-19 06:34:59]

On 2015/02/19 06:29:35, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Err... WTF?  Any ideas why webgl_conformance would be affected by this CL?

[jln (very slow on Chromium), 2015-02-19 18:07:57]

On 2015/02/19 06:34:59, mdempsky wrote:
> On 2015/02/19 06:29:35, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> Err... WTF?  Any ideas why webgl_conformance would be affected by this CL?

This is so odd. I'll try the CQ another time...

[jln (very slow on Chromium), 2015-02-19 18:08:00]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2015-02-19 18:08:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/928963003/20001

[commit-bot: I haz the power, 2015-02-19 18:38:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-19 18:38:40]

Patchset 2 (id:??) landed as
https://crrev.com/b71febc45698e4cae48c92c7a99d235da41adb55
Cr-Commit-Position: refs/heads/master@{#317080}