Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 928913002: Remove Test DISABLED_CongestionAvoidanceSending (Closed)

Created:
5 years, 10 months ago by zhuoyu.qian
Modified:
5 years, 9 months ago
CC:
asanka, cbentzel+watch_chromium.org, chromium-reviews, Ian Swett, Ryan Hamilton
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Test DISABLED_CongestionAvoidanceSending Remove the test as the TODO comment in pacing_sender_test.cc by ianswett. BUG= R=asanka@chromium.org Committed: https://crrev.com/bc629b9cc9f3626f55b7f49927d0acf6ba0cf240 Cr-Commit-Position: refs/heads/master@{#318209}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -58 lines) Patch
M net/quic/congestion_control/pacing_sender_test.cc View 1 chunk +0 lines, -58 lines 3 comments Download

Messages

Total messages: 11 (3 generated)
zhuoyu.qian
5 years, 10 months ago (2015-02-16 02:39:36 UTC) #1
asanka
asanka -> rtenneti Why remove? Can this test be fixed or is it not necessary?
5 years, 10 months ago (2015-02-17 18:50:01 UTC) #4
ramant (doing other things)
https://codereview.chromium.org/928913002/diff/1/net/quic/congestion_control/pacing_sender_test.cc File net/quic/congestion_control/pacing_sender_test.cc (left): https://codereview.chromium.org/928913002/diff/1/net/quic/congestion_control/pacing_sender_test.cc#oldcode197 net/quic/congestion_control/pacing_sender_test.cc:197: // TODO(ianswett): Remove this test. Please don't remove this ...
5 years, 10 months ago (2015-02-17 18:52:53 UTC) #5
asanka
https://codereview.chromium.org/928913002/diff/1/net/quic/congestion_control/pacing_sender_test.cc File net/quic/congestion_control/pacing_sender_test.cc (left): https://codereview.chromium.org/928913002/diff/1/net/quic/congestion_control/pacing_sender_test.cc#oldcode197 net/quic/congestion_control/pacing_sender_test.cc:197: // TODO(ianswett): Remove this test. On 2015/02/17 at 18:52:53, ...
5 years, 10 months ago (2015-02-18 17:17:38 UTC) #6
ramant (doing other things)
lgtm https://codereview.chromium.org/928913002/diff/1/net/quic/congestion_control/pacing_sender_test.cc File net/quic/congestion_control/pacing_sender_test.cc (left): https://codereview.chromium.org/928913002/diff/1/net/quic/congestion_control/pacing_sender_test.cc#oldcode197 net/quic/congestion_control/pacing_sender_test.cc:197: // TODO(ianswett): Remove this test. On 2015/02/18 17:17:37, ...
5 years, 10 months ago (2015-02-23 21:53:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928913002/1
5 years, 9 months ago (2015-02-26 07:31:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-26 08:08:07 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 08:08:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc629b9cc9f3626f55b7f49927d0acf6ba0cf240
Cr-Commit-Position: refs/heads/master@{#318209}

Powered by Google App Engine
This is Rietveld 408576698