runtime/vm/instructions_arm64.cc - Issue 928833003: Add Function based profile tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/instructions_arm64.cc

Issue 928833003: Add Function based profile tree (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/instructions_arm64.cc

diff --git a/runtime/vm/instructions_arm64.cc b/runtime/vm/instructions_arm64.cc

index de513c7b6534e3bfd7aabb83d418317efd7eae9d..aea111fdc4d1e78a07a5d48ed21466b6c1d2139c 100644

--- a/runtime/vm/instructions_arm64.cc

+++ b/runtime/vm/instructions_arm64.cc

@@ -365,6 +365,19 @@ void JumpPattern::SetTargetAddress(uword target_address) const {

CPU::FlushICache(pc_, 4 * Instr::kInstrSize);

}

+ReturnPattern::ReturnPattern(uword pc)

+ : pc_(pc) {

siva 2015/02/25 22:58:38 Ditto comment about inlining this constructor.

+bool ReturnPattern::IsValid() const {

+ Instr* bx_lr = Instr::At(pc_);

+ const Register crn = ConcreteRegister(LR);

+ const int32_t instruction = RET | (static_cast<int32_t>(crn) << kRnShift);

+ return bx_lr->InstructionBits() == instruction;

} // namespace dart

#endif // defined TARGET_ARCH_ARM64