Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/instructions_arm.h

Issue 928833003: Add Function based profile tree (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/observatory/lib/src/cpu_profile/cpu_profile.dart ('K') | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/instructions_arm.cc » ('j') | runtime/vm/instructions_arm.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_arm.h
diff --git a/runtime/vm/instructions_arm.h b/runtime/vm/instructions_arm.h
index b802fa6b03a2f1c56a26174393884db09b9295df..a9eedc56b6f4cabd02abf5e20a1a0c9313aefee9 100644
--- a/runtime/vm/instructions_arm.h
+++ b/runtime/vm/instructions_arm.h
@@ -96,6 +96,24 @@ class JumpPattern : public ValueObject {
DISALLOW_COPY_AND_ASSIGN(JumpPattern);
};
+
+class ReturnPattern : public ValueObject {
+ public:
+ ReturnPattern(uword pc);
siva 2015/02/25 22:58:38 explicit ?
Cutch 2015/02/26 18:44:40 Done.
+
+ // bx_lr = 1.
+ static const int kLengthInBytes = 1*Instr::kInstrSize;
siva 2015/02/25 22:58:38 spaces (1 * Instr)
Cutch 2015/02/26 18:44:40 Done (here and elsewhere).
+
+ int pattern_length_in_bytes() const {
siva 2015/02/25 22:58:38 This is not an accessor but it has the naming styl
Cutch 2015/02/26 18:44:40 Acknowledged.
+ return kLengthInBytes;
+ }
+
+ bool IsValid() const;
+
+ private:
+ const uword pc_;
+};
+
} // namespace dart
#endif // VM_INSTRUCTIONS_ARM_H_
« runtime/observatory/lib/src/cpu_profile/cpu_profile.dart ('K') | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/instructions_arm.cc » ('j') | runtime/vm/instructions_arm.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698