Add Function based profile tree

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 5075 matching lines @@
 void Function::ClearCode() const {
   StorePointer(&raw_ptr()->unoptimized_code_, Code::null());
   StubCode* stub_code = Isolate::Current()->stub_code();
   StorePointer(&raw_ptr()->instructions_,
       Code::Handle(stub_code->LazyCompile_entry()->code()).instructions());
 }
 
 
 void Function::SwitchToUnoptimizedCode() const {
   ASSERT(HasOptimizedCode());
-  const Code& current_code = Code::Handle(CurrentCode());
+  Isolate* isolate = Isolate::Current();
+  const Code& current_code = Code::Handle(isolate, CurrentCode());
 
   if (FLAG_trace_disabling_optimized_code) {
     OS::Print("Disabling optimized code: '%s' entry: %#" Px "\n",
       ToFullyQualifiedCString(),
       current_code.EntryPoint());
   }
   // Patch entry of the optimized code.
   CodePatcher::PatchEntry(current_code);
   // Use previously compiled unoptimized code.
-  AttachCode(Code::Handle(unoptimized_code()));
-  CodePatcher::RestoreEntry(Code::Handle(unoptimized_code()));
+  AttachCode(Code::Handle(isolate, unoptimized_code()));
+  CodePatcher::RestoreEntry(Code::Handle(isolate, unoptimized_code()));
+  isolate->TrackDeoptimizedCode(current_code);
 }
 
 
 void Function::set_unoptimized_code(const Code& value) const {
   ASSERT(!value.is_optimized());
   StorePointer(&raw_ptr()->unoptimized_code_, value.raw());
 }
 
 
 RawContextScope* Function::context_scope() const {
@@ skipping 7425 matching lines @@
       // Only disassemble alive code objects.
       DisassembleToJSONStream formatter(jsarr);
       Disassemble(&formatter);
     }
   }
   const PcDescriptors& descriptors = PcDescriptors::Handle(pc_descriptors());
   if (!descriptors.IsNull()) {
     JSONObject desc(&jsobj, "descriptors");
     descriptors.PrintToJSONObject(&desc, false);
   }
+  const Array& inlined_function_table = Array::Handle(inlined_id_to_function());
+  if (!inlined_function_table.IsNull()) {
+    JSONArray inlined_functions(&jsobj, "inlinedFunctions");
+    Function& function = Function::Handle();
+    for (intptr_t i = 0; i < inlined_function_table.Length(); i++) {
+      function ^= inlined_function_table.At(i);
+      ASSERT(!function.IsNull());
+      inlined_functions.AddValue(function);
+    }
+  }
+  const Array& intervals = Array::Handle(inlined_intervals());
+  if (!intervals.IsNull()) {
+    Smi& start = Smi::Handle();
+    Smi& end = Smi::Handle();
+    JSONArray inline_intervals(&jsobj, "inlinedIntervals");
+    for (intptr_t i = 0; i < intervals.Length() - Code::kInlIntNumEntries;
+         i += Code::kInlIntNumEntries) {
+      start ^= intervals.At(i + Code::kInlIntStart);
+      if (start.IsNull()) {
+        continue;
+      }
+      end ^= intervals.At(i + Code::kInlIntNumEntries + Code::kInlIntStart);
+
+      // Format: [start, end, inline functions...]
+      JSONArray inline_interval(&inline_intervals);
+      inline_interval.AddValue(start.Value());
+      inline_interval.AddValue(end.Value());
+
+      Smi& temp_smi = Smi::Handle();

[siva, 2015/02/25 22:58:39]

This handle can be hoisted out of the for loop?

[Cutch, 2015/02/26 18:44:40]

Done.

+      temp_smi ^= intervals.At(i + Code::kInlIntInliningId);
+      intptr_t inlining_id = temp_smi.Value();
+      ASSERT(inlining_id >= 0);
+      temp_smi ^= intervals.At(i + Code::kInlIntCallerId);
+      intptr_t caller_id = temp_smi.Value();
+      while (inlining_id >= 0) {
+        inline_interval.AddValue(inlining_id);
+        inlining_id = caller_id;
+        caller_id = GetCallerId(inlining_id);
+      }
+    }
+  }
 }
 
 
 uword Code::GetEntryPatchPc() const {
   return (entry_patch_pc_offset() != kInvalidPc)
       ? EntryPoint() + entry_patch_pc_offset() : 0;
 }
 
 
 uword Code::GetPatchCodePc() const {
@@ skipping 8061 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart