Add Function based profile tree

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "vm/code_observers.h"
@@ skipping 475 matching lines @@
       last_allocationprofile_accumulator_reset_timestamp_(0),
       last_allocationprofile_gc_timestamp_(0),
       cha_(NULL),
       object_id_ring_(NULL),
       trace_buffer_(NULL),
       profiler_data_(NULL),
       thread_state_(NULL),
       tag_table_(GrowableObjectArray::null()),
       current_tag_(UserTag::null()),
       default_tag_(UserTag::null()),
+      deoptimized_code_array_(GrowableObjectArray::null()),
       metrics_list_head_(NULL),
       next_(NULL),
       REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_INITIALIZERS)
       REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_SCOPE_INIT)
       reusable_handles_() {
   set_vm_tag(VMTag::kIdleTagId);
   set_user_tag(UserTags::kDefaultUserTag);
 }
 
 Isolate::Isolate(Isolate* original)
@@ skipping 738 matching lines @@
 
   // Visit the current tag which is stored in the isolate.
   visitor->VisitPointer(reinterpret_cast<RawObject**>(&current_tag_));
 
   // Visit the default tag which is stored in the isolate.
   visitor->VisitPointer(reinterpret_cast<RawObject**>(&default_tag_));
 
   // Visit the tag table which is stored in the isolate.
   visitor->VisitPointer(reinterpret_cast<RawObject**>(&tag_table_));
 
+  // Visit the deoptimized code array which is stored in the isolate.
+  visitor->VisitPointer(
+      reinterpret_cast<RawObject**>(&deoptimized_code_array_));
+
   // Visit objects in the debugger.
   debugger()->VisitObjectPointers(visitor);
 
   // Visit objects that are being used for deoptimization.
   if (deopt_context() != NULL) {
     deopt_context()->VisitObjectPointers(visitor);
   }
 }
 
 
@@ skipping 177 matching lines @@
   set_user_tag(user_tag);
   current_tag_ = tag.raw();
 }
 
 
 void Isolate::set_default_tag(const UserTag& tag) {
   default_tag_ = tag.raw();
 }
 
 
+void Isolate::set_deoptimized_code_array(const GrowableObjectArray& value) {
+  deoptimized_code_array_ = value.raw();

[siva, 2015/02/25 22:58:39]

StorePointer(...);

I think we are missing this with some of the tag stuff too (e.g tag_table_,
current_tag_, default_tag_)

[Cutch, 2015/02/26 18:44:40]

Acknowledged.

+}
+
+
+void Isolate::TrackDeoptimizedCode(const Code& code) {
+  ASSERT(!code.IsNull());
+  const GrowableObjectArray& deoptimized_code =
+      GrowableObjectArray::Handle(deoptimized_code_array());
+  if (deoptimized_code.IsNull()) {
+    // Not tracking deoptimized code.
+    return;
+  }
+  deoptimized_code.Add(code);

[siva, 2015/02/25 22:58:39]

Can you add a TODO here that we will make this and the profiler samples GC aware
structures so that it can free up code objects which are not referenced in the
profile.

[Cutch, 2015/02/26 18:44:40]

Done.

+}
+
+
 void Isolate::VisitIsolates(IsolateVisitor* visitor) {
   if (visitor == NULL) {
     return;
   }
   MonitorLocker ml(isolates_list_monitor_);
   Isolate* current = isolates_list_head_;
   while (current) {
     visitor->VisitIsolate(current);
     current = current->next_;
   }
@@ skipping 239 matching lines @@
                            serialized_message_, serialized_message_len_);
 }
 
 
 void IsolateSpawnState::Cleanup() {
   SwitchIsolateScope switch_scope(I);
   Dart::ShutdownIsolate();
 }
 
 }  // namespace dart