Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 928733003: Temporarily disable double fields unboxing. (Closed)

Created:
5 years, 10 months ago by Igor Sheludko
Modified:
5 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Michael Achenbach, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Temporarily disable double fields unboxing. Committed: https://crrev.com/209cf09ac9e36c1a24cdfa918bc579a4671c6842 Cr-Commit-Position: refs/heads/master@{#26727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/globals.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Igor Sheludko
5 years, 10 months ago (2015-02-18 16:22:23 UTC) #2
Jakob Kummerow
LGTM. Michael, Michael: We should either cut the branch after this commit, or backmerge it.
5 years, 10 months ago (2015-02-18 16:26:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928733003/1
5 years, 10 months ago (2015-02-18 16:27:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 16:44:58 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/209cf09ac9e36c1a24cdfa918bc579a4671c6842 Cr-Commit-Position: refs/heads/master@{#26727}
5 years, 10 months ago (2015-02-18 16:45:14 UTC) #7
Igor Sheludko
5 years, 10 months ago (2015-02-26 12:26:31 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/960173002/ by ishell@chromium.org.

The reason for reverting is: Preparing to land a fix..

Powered by Google App Engine
This is Rietveld 408576698