Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: content/browser/renderer_host/render_view_host_delegate.h

Issue 92873004: Prevent the browser process from creating duplicate RenderViewHosts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't kill invalid process. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 // Requests to lock the mouse. Once the request is approved or rejected, 375 // Requests to lock the mouse. Once the request is approved or rejected,
376 // GotResponseToLockMouseRequest() will be called on the requesting render 376 // GotResponseToLockMouseRequest() will be called on the requesting render
377 // view host. 377 // view host.
378 virtual void RequestToLockMouse(bool user_gesture, 378 virtual void RequestToLockMouse(bool user_gesture,
379 bool last_unlocked_by_target) {} 379 bool last_unlocked_by_target) {}
380 380
381 // Notification that the view has lost the mouse lock. 381 // Notification that the view has lost the mouse lock.
382 virtual void LostMouseLock() {} 382 virtual void LostMouseLock() {}
383 383
384 // The page is trying to open a new page (e.g. a popup window). The window 384 // The page is trying to open a new page (e.g. a popup window). The window
385 // should be created associated with the given route, but it should not be 385 // should be created associated with the given route, but it should not be
Charlie Reis 2013/12/02 19:22:50 nit: given |route_id| in process |render_process_i
nasko 2013/12/02 20:19:13 Done.
386 // shown yet. That should happen in response to ShowCreatedWindow. 386 // shown yet. That should happen in response to ShowCreatedWindow.
387 // |params.window_container_type| describes the type of RenderViewHost 387 // |params.window_container_type| describes the type of RenderViewHost
388 // container that is requested -- in particular, the window.open call may 388 // container that is requested -- in particular, the window.open call may
389 // have specified 'background' and 'persistent' in the feature string. 389 // have specified 'background' and 'persistent' in the feature string.
390 // 390 //
391 // The passed |params.frame_name| parameter is the name parameter that was 391 // The passed |params.frame_name| parameter is the name parameter that was
392 // passed to window.open(), and will be empty if none was passed. 392 // passed to window.open(), and will be empty if none was passed.
393 // 393 //
394 // Note: this is not called "CreateWindow" because that will clash with 394 // Note: this is not called "CreateWindow" because that will clash with
395 // the Windows function which is actually a #define. 395 // the Windows function which is actually a #define.
396 virtual void CreateNewWindow( 396 virtual void CreateNewWindow(
397 int render_process_id,
397 int route_id, 398 int route_id,
398 int main_frame_route_id, 399 int main_frame_route_id,
399 const ViewHostMsg_CreateWindow_Params& params, 400 const ViewHostMsg_CreateWindow_Params& params,
400 SessionStorageNamespace* session_storage_namespace) {} 401 SessionStorageNamespace* session_storage_namespace) {}
401 402
402 // The page is trying to open a new widget (e.g. a select popup). The 403 // The page is trying to open a new widget (e.g. a select popup). The
403 // widget should be created associated with the given route, but it should 404 // widget should be created associated with the given route, but it should
404 // not be shown yet. That should happen in response to ShowCreatedWidget. 405 // not be shown yet. That should happen in response to ShowCreatedWidget.
405 // |popup_type| indicates if the widget is a popup and what kind of popup it 406 // |popup_type| indicates if the widget is a popup and what kind of popup it
406 // is (select, autofill...). 407 // is (select, autofill...).
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 // created by the RenderViewHost. 452 // created by the RenderViewHost.
452 virtual FrameTree* GetFrameTree(); 453 virtual FrameTree* GetFrameTree();
453 454
454 protected: 455 protected:
455 virtual ~RenderViewHostDelegate() {} 456 virtual ~RenderViewHostDelegate() {}
456 }; 457 };
457 458
458 } // namespace content 459 } // namespace content
459 460
460 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ 461 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698